[Discover][Embeddable] Fix search highlighting #197607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:fix
v9.0.0
Team:DataDiscovery
jughosta
changed the title
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @jughosta |
davismcphee
approved these changes
Oct 24, 2024
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing it!
Contributor
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11513458512 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
- Closes elastic#197195 ## Summary This PR fixes the search highlights for saved search panels on Dashboard. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2b645d5)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
- Closes elastic#197195 ## Summary This PR fixes the search highlights for saved search panels on Dashboard. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2b645d5)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Discover][Embeddable] Fix search highlighting (#197607)](#197607) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T07:01:22Z","message":"[Discover][Embeddable] Fix search highlighting (#197607)\n\n- Closes https://github.com/elastic/kibana/issues/197195\r\n\r\n## Summary\r\n\r\nThis PR fixes the search highlights for saved search panels on\r\nDashboard.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2b645d56b76dd44f84e1c4c31a1336260513c6b2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","v8.16.0","backport:version","v8.17.0"],"title":"[Discover][Embeddable] Fix search highlighting ","number":197607,"url":"https://github.com/elastic/kibana/pull/197607","mergeCommit":{"message":"[Discover][Embeddable] Fix search highlighting (#197607)\n\n- Closes https://github.com/elastic/kibana/issues/197195\r\n\r\n## Summary\r\n\r\nThis PR fixes the search highlights for saved search panels on\r\nDashboard.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2b645d56b76dd44f84e1c4c31a1336260513c6b2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197607","number":197607,"mergeCommit":{"message":"[Discover][Embeddable] Fix search highlighting (#197607)\n\n- Closes https://github.com/elastic/kibana/issues/197195\r\n\r\n## Summary\r\n\r\nThis PR fixes the search highlights for saved search panels on\r\nDashboard.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2b645d56b76dd44f84e1c4c31a1336260513c6b2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
) # Backport This will backport the following commits from `main` to `8.16`: - [[Discover][Embeddable] Fix search highlighting (#197607)](#197607) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T07:01:22Z","message":"[Discover][Embeddable] Fix search highlighting (#197607)\n\n- Closes https://github.com/elastic/kibana/issues/197195\r\n\r\n## Summary\r\n\r\nThis PR fixes the search highlights for saved search panels on\r\nDashboard.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2b645d56b76dd44f84e1c4c31a1336260513c6b2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:DataDiscovery","v8.16.0","backport:version","v8.17.0"],"title":"[Discover][Embeddable] Fix search highlighting ","number":197607,"url":"https://github.com/elastic/kibana/pull/197607","mergeCommit":{"message":"[Discover][Embeddable] Fix search highlighting (#197607)\n\n- Closes https://github.com/elastic/kibana/issues/197195\r\n\r\n## Summary\r\n\r\nThis PR fixes the search highlights for saved search panels on\r\nDashboard.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2b645d56b76dd44f84e1c4c31a1336260513c6b2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197607","number":197607,"mergeCommit":{"message":"[Discover][Embeddable] Fix search highlighting (#197607)\n\n- Closes https://github.com/elastic/kibana/issues/197195\r\n\r\n## Summary\r\n\r\nThis PR fixes the search highlights for saved search panels on\r\nDashboard.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2b645d56b76dd44f84e1c4c31a1336260513c6b2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the search highlights for saved search panels on Dashboard.
Checklist