[ML] Fix Single Metric Viewer for multi week bucket spans #19759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
v6.4.0
:ml
Feature:ml-results
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the loading of data for the chart in the Single Metric Viewer for jobs where the bucket span is a multiple of a week (or higher) unit (e.g. 14d, 28d).
Multi unit durations are now converted to a maximum unit of
days, where before they could be converted toweeksor longer, since units greater thandare not supported for use as durations in elasticsearch (see https://www.elastic.co/guide/en/elasticsearch/reference/current/common-options.html#time-units). So whilst it is ok to convert a duration of60sto1m, converting a duration of14dto2wwill cause an error when used in an aggregation.Example of a job with a bucket span of
14dnow being displayed correctly in the Single Metric Viewer:Fixes #19720