Skip to content

[Lens] Fix switchVisualizationType to use it without layerId #196295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbondyra merged 2 commits into from
Oct 15, 2024
Merged

[Lens] Fix switchVisualizationType to use it without layerId #196295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
948b99e
[Lens] fix suggestions api (allow not pass layerId to switch Visualiz…
mbondyra Oct 15, 2024
0ac6c5c
Update x-pack/plugins/lens/public/visualizations/xy/visualization.tsx
mbondyra Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions x-pack/plugins/lens/public/visualizations/xy/visualization.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4214,4 +4214,30 @@ describe('xy_visualization', () => {
`);
});
});
describe('switchVisualizationType', () => {
it('should switch all the layers to the new visualization type if layerId is not specified (AI assistant case)', () => {
const state = exampleState();
state.layers[1] = state.layers[0];
state.layers[1].layerId = 'second';
state.layers[2] = state.layers[0];
state.layers[2].layerId = 'third';
const newType = 'bar';
const newState = xyVisualization.switchVisualizationType!(newType, state);
expect((newState.layers[0] as XYDataLayerConfig).seriesType).toEqual(newType);
expect((newState.layers[1] as XYDataLayerConfig).seriesType).toEqual(newType);
expect((newState.layers[2] as XYDataLayerConfig).seriesType).toEqual(newType);
});
it('should switch only the second layer to the new visualization type if layerId is specified (chart switch case)', () => {
const state = exampleState();
state.layers[1] = { ...state.layers[0] };
state.layers[1].layerId = 'second';
state.layers[2] = { ...state.layers[0] };
state.layers[2].layerId = 'third';
const newType = 'bar';
const newState = xyVisualization.switchVisualizationType!(newType, state, 'first');
expect((newState.layers[0] as XYDataLayerConfig).seriesType).toEqual(newType);
expect((newState.layers[1] as XYDataLayerConfig).seriesType).toEqual('area');
expect((newState.layers[2] as XYDataLayerConfig).seriesType).toEqual('area');
});
});
});
5 changes: 3 additions & 2 deletions x-pack/plugins/lens/public/visualizations/xy/visualization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,14 +263,15 @@ export const getXyVisualization = ({
getDescription,

switchVisualizationType(seriesType: string, state: State, layerId?: string) {
const dataLayer = state.layers.find((l) => l.layerId === layerId);
const dataLayer = layerId
? state.layers.find((l) => l.layerId === layerId)
: state.layers.at(0);
if (dataLayer && !isDataLayer(dataLayer)) {
throw new Error('Cannot switch series type for non-data layer');
}
if (!dataLayer) {
return state;
}
// todo: test how they switch between percentage etc
const currentStackingType = stackingTypes.find(({ subtypes }) =>
subtypes.includes(dataLayer.seriesType)
);
Expand Down