[APM] Fix APM breadcrumbs on Serverless #191506

crespocarlos · 2024-08-27T14:53:15Z

fixes #8
fixes #7

Summary

Fixes APM breadcrumbs on serverless

Serverless	Stateful

How to test

Serverless

Start a local ES serverless instance: yarn es serverless --projectType=oblt --ssl -k/--insecure
Start a local Kibana serverless instance: yarn start --serverless=oblt --no-ssl
Run some synthtrace scenarios
- NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace mobile.ts --live --target=https://elastic_serverless:[email protected]:9200 --kibana=http://elastic_serverless:[email protected]:5601
- NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace service_map.ts --live --target=https://elastic_serverless:[email protected]:9200 --kibana=http://elastic_serverless:[email protected]:5601
Navigate to Applications and click through the links

Stateful

Start a local ES and Kibana instance
Run the some synthtrace scenarios:
- node scripts/synthtrace mobile.ts --live
- node scripts/synthtrace service_map.ts --live
Navigate to Applications and click through the links

obltmachine · 2024-08-27T14:53:29Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

crespocarlos · 2024-08-27T14:56:05Z

/ci

crespocarlos · 2024-08-28T08:45:24Z

/ci

…eadcrumbs

elasticmachine · 2024-08-28T12:40:42Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine · 2024-08-28T12:40:42Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

crespocarlos · 2024-08-28T13:10:15Z

x-pack/plugins/observability_solution/apm/public/components/app/breadcrumb/index.tsx

-    [core.http.basePath, href, title]
+    [core.http.basePath, href, title],
+    {
+      omitOnServerless,


Note
Side nav items are automatically added, so we have to avoid adding repeated items to the breadcrumbs

crespocarlos · 2024-08-28T13:11:31Z

...ns/observability_solution/apm/public/components/routing/templates/service_group_template.tsx

+          ],
+    [pagePath, pageTitle, query, router, selectedTab, serviceGroupName, serviceGroupsLink],
+    {
+      omitRootOnServerless: true,


Note
Services is automatically added on serverless

crespocarlos · 2024-08-28T13:12:23Z

x-pack/plugins/observability_solution/apm/public/components/routing/home/index.tsx

  return {
    [path]: {
      element: (
-        <Breadcrumb title={title} href={path}>


Note
was removed to avoid conflicts with useBreadcrumb in ServiceGroupTemplate

totally off topic: never knew about these alert indicators. I'll immediately start (ab)-using these! :)

Other type of alerts per my recent findings:

Note
Highlights information that users should take into account, even when skimming.

Tip
Optional information to help a user be more successful.

Important
Crucial information necessary for users to succeed.

Warning
Critical content demanding immediate user attention due to potential risks.

Caution
Negative potential consequences of an action.

I have to say that I found that out a couple of days ago in one of @tonyghiani's PRs. 😄

afharo

kibana.jsonc changes LGTM

MiriamAparicio

LGTM, thanks for doing this!

…eadcrumbs

dominiqueclarke

obs-ux-management changes LGTM

crespocarlos · 2024-08-30T10:46:59Z

@elasticmachine merge upstream

kibana-ci · 2024-08-30T11:42:14Z

💚 Build Succeeded

Buildkite Build
Commit: a011991
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191506-a01199122186

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.5MB	3.5MB	+459.0B
`exploratoryView`	184.3KB	184.3KB	+6.0B
`observability`	460.0KB	460.1KB	+28.0B
total			+493.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityShared`	68.5KB	68.7KB	+174.0B

History

💔 Build #231018 failed df16456
💛 Build #230415 was flaky d5ae659
💚 Build #230353 succeeded 004df37
💔 Build #230150 failed b9701c13aa1ef536a9e8e86bc139eda6c576c134

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Fix APM breadcrumbs on Serverless

f2dbcd2

crespocarlos force-pushed the a11y-fix-apm-breadcrumbs branch from b9701c1 to f2dbcd2 Compare August 27, 2024 15:01

kibanamachine and others added 3 commits August 27, 2024 15:06

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

27a71cf

Fix service inventory breadcrumbs

6510524

revert infra changes

004df37

crespocarlos marked this pull request as ready for review August 28, 2024 12:38

crespocarlos requested review from a team as code owners August 28, 2024 12:38

Merge branch 'main' of github.com:elastic/kibana into a11y-fix-apm-br…

d5ae659

…eadcrumbs

botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Aug 28, 2024

crespocarlos added v8.16.0 release_note:skip Skip the PR/issue when compiling release notes and removed Team:obs-ux-management Observability Management User Experience Team labels Aug 28, 2024

crespocarlos commented Aug 28, 2024

View reviewed changes

botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Aug 28, 2024

crespocarlos commented Aug 28, 2024

View reviewed changes

afharo approved these changes Aug 28, 2024

View reviewed changes

MiriamAparicio approved these changes Aug 29, 2024

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into a11y-fix-apm-br…

df16456

…eadcrumbs

dominiqueclarke approved these changes Aug 29, 2024

View reviewed changes

crespocarlos enabled auto-merge (squash) August 30, 2024 07:39

Merge branch 'main' into a11y-fix-apm-breadcrumbs

a011991

crespocarlos merged commit 60b8c05 into elastic:main Aug 30, 2024

kibanamachine added the backport:skip This PR does not require backporting label Aug 30, 2024

crespocarlos deleted the a11y-fix-apm-breadcrumbs branch August 30, 2024 12:15

mgiota mentioned this pull request Oct 11, 2024

[APM] Breadcrumbs are broken on new nav experience #195994

Open

[APM] Fix APM breadcrumbs on Serverless #191506

[APM] Fix APM breadcrumbs on Serverless #191506

Uh oh!

Conversation

crespocarlos commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Serverless

Stateful

Uh oh!

obltmachine commented Aug 27, 2024

🤖 GitHub comments

Uh oh!

crespocarlos commented Aug 27, 2024

Uh oh!

crespocarlos commented Aug 28, 2024

Uh oh!

elasticmachine commented Aug 28, 2024

Uh oh!

elasticmachine commented Aug 28, 2024

Uh oh!

crespocarlos Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

crespocarlos Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

crespocarlos Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

crespocarlos Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

MiriamAparicio left a comment

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

crespocarlos commented Aug 30, 2024

Uh oh!

kibana-ci commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

crespocarlos commented Aug 27, 2024 •

edited

Loading

kibana-ci commented Aug 30, 2024 •

edited

Loading