async-import plugins in the server side

[afharo]

Summary

When Kibana starts, it has to import the file ${plugin}/server/index for all the plugins in order to read the config variable that it's exported from that file.

Since the index file for each plugin loads the ./plugin file, it's indirectly loading all the files of the plugin in one go. This essentially makes Kibana load all the server-side code from all the plugins, even when the plugins might be disabled. While it wasn't a big deal in the Classic offering (most plugins are enabled), on Serverless we are disabling a lot of plugins (and also adding a good amount of Serverless-specific plugins that shouldn't load on Classic).

This PR changes all the ${plugin}/server/index files to follow a pattern like:

import type { PluginConfigDescriptor, PluginInitializerContext } from '@kbn/core/server';

import { configSchema } from './config';

export const config: PluginConfigDescriptor<TypeOf<typeof configSchema>> = {
  schema: configSchema,
};

export const plugin = async (context: PluginInitializerContext) => {
  const { MyPlugin } = await import('./plugin'); // <-- The import has been moved here
  return new MyPlugin(context);
};

Checklist

• Documentation was added for features that require explanation or tutorials
• Change the plugin generator's template.

Risk Matrix

Risk	Probability	Severity	Mitigation/Notes
Kibana might show logs in a different order.	Low	Low	One of the FTRs failed because Kibana is now able to report unavailable status before it is actually serving any HTTP traffic. Commit 0404c34 fixed the FTR, but that means we might expect things to slightly change the order in which they occur when Kibana is starting. This should only affect automations that depend on specific log entries because Kibana won't report available until all plugins are correctly setup.

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[afharo]

@afharo it would be nice if we could have an ES Lint rule to enforce this pattern

@opauloh, that's a great idea! I've created #171080 to tackle it since it looks to me like an effort on its own 😇

[ymao1]

Response Ops changes LGTM. Code review only

[sabarasaba]

deployment management changes lgtm!

[stratoula]

Thanx for your work here Alejandro! Visualizations team numerous plugins changes LGTM 😄

[cnasikas]

ResponseOps changes LGTM!

[kc13greiner]

Kb Security changes LGTM!

[e40pud]

DE changes LGTM!

[robbavey]

Logstash changes LGTM

[logeekal]

Desk tested security solution and timelines. Both working well. LGTM 🚀

[michaelolo24]

Looks great, thanks @afharo !

[PhilippeOberti]

LGTM for Protections Experience team :)

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 1e61fce
• Storybooks Preview

Failed CI Steps

• Jest Tests #19

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
mapsEms	68	60	-8

Unknown metric groups

API count

id	before	after	diff
mapsEms	68	60	-8

History

• 💔 Build #175809 failed fca5b21
• 💔 Build #175749 failed cce6d38
• 💚 Build #175134 succeeded a7038ae
• 💚 Build #174933 succeeded 0404c34

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo