Skip to content

Conversation

@peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jul 18, 2023

Summary

Adds accessibility tests for the categorization and data recognizer anomaly detection job wizards.

As part of this PR I have split out the tests for the anomaly detection pages into a separate file as the original ml.ts file was getting very large.

Part of #160712
Part of #88496

Checklist

@peteharverson peteharverson added :ml release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.10.0 labels Jul 18, 2023
@peteharverson peteharverson self-assigned this Jul 18, 2023
@peteharverson peteharverson requested a review from a team as a code owner July 18, 2023 10:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +201.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@qn895
Copy link
Member

qn895 commented Jul 18, 2023

LGTM 🎉

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit 46403f1 into elastic:main Jul 19, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 19, 2023
@peteharverson peteharverson deleted the ml-add-ad-a11y-tests branch July 19, 2023 13:03
Ruhshan pushed a commit to Ruhshan/kibana that referenced this pull request Jul 19, 2023
…lastic#162126)

## Summary

Adds accessibility tests for the categorization and data recognizer
anomaly detection job wizards.

As part of this PR I have split out the tests for the anomaly detection
pages into a separate file as the original `ml.ts` file was getting very
large.

Part of elastic#160712
Part of elastic#88496

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
…lastic#162126)

## Summary

Adds accessibility tests for the categorization and data recognizer
anomaly detection job wizards.

As part of this PR I have split out the tests for the anomaly detection
pages into a separate file as the original `ml.ts` file was getting very
large.

Part of elastic#160712
Part of elastic#88496

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Oct 11, 2024
Contributes to: elastic#194817

Why I assigned them:

Assigned advanced_settings due to elastic#175255

Assigned dashboard_controls due to elastic#190797

Assigned dashboard_links due to elastic#174772

Assigned dashboard_panel_options due to elastic#178596

Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned helpers due to elastic#164341 (call site)

Assigned home due to elastic#103192

Assigned index_lifecycle_management due to elastic#116207

Assigned ingest_node_pipelines due to elastic#113783

Assigned kibana_overview due to  https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned management due to elastic#165705

Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4

Assigned search_profiler due to elastic#195343

Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4

Assigned lens due to elastic#175893

Assigned ml_anomaly_detection due to elastic#162126

Assigned canvas due to elastic#164376

Assigned cc replication due to elastic#149069

Assigned enterpise search due to elastic#79359

Assigned graph to due elastic#190797

Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4

Assigned maps due to elastic#155161

Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4

Assigned remote clusters due to elastic#96989

Assigned reporting due to elastic#121435

Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4

Assigned watcher due to elastic#119717
wayneseymour added a commit that referenced this pull request Oct 22, 2024
## Summary

Assign files within `x-pack/test/accessibility/apps/group[1|2|3]`

### Why I assigned them:

Assigned advanced_settings due to
#175255

Assigned dashboard_controls due to
#190797

Assigned dashboard_links due to
#174772

Assigned dashboard_panel_options due to
#178596

Assigned grok_debugger due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned helpers due to #164341
(call site)

Assigned home due to #103192

Assigned index_lifecycle_management due to
#116207

Assigned ingest_node_pipelines due to
#113783

Assigned kibana_overview due to
https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned management due to #165705

Assigned painless_lab due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4

Assigned search_profiler due to
#195343

Assigned uptime due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4

Assigned lens due to #175893

Assigned ml_anomaly_detection due to
#162126

Assigned canvas due to #164376

Assigned cc replication due to
#149069

Assigned enterpise search due to
#79359

Assigned graph to due #190797

Assigned license_management due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4

Assigned maps due to #155161

Assigned observability due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4

Assigned remote clusters due to
#96989

Assigned reporting due to #121435

Assigned rollup_jobs due to
https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4

Assigned watcher due to #119717


Contributes to: #194817

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Rodney Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants