From 58110251850e8577e157d84937a3db18c643f3f8 Mon Sep 17 00:00:00 2001 From: Julia Rechkunova Date: Wed, 26 Apr 2023 08:30:55 +0200 Subject: [PATCH] [Discover] Remove redundant "Filter was added" toast (#155645) Closes https://github.com/elastic/kibana/issues/154993 ## Summary This PR removes "Filter was added" toast (it was visible after adding filters from the Doc Viewer flyout) which was not very useful. It's also not shown when user adds filters from the grid or sidebar. (cherry picked from commit 7534cc78511febd457b3ea1efca8b8c0057850de) --- .../discover_grid/discover_grid_flyout.tsx | 13 +------------ x-pack/plugins/translations/translations/fr-FR.json | 1 - x-pack/plugins/translations/translations/ja-JP.json | 1 - x-pack/plugins/translations/translations/zh-CN.json | 1 - 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx b/src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx index dd541a9cc4de8..ade63023dd7bc 100644 --- a/src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx +++ b/src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx @@ -217,18 +217,7 @@ export function DiscoverGridFlyout({ hit={actualHit} columns={columns} dataView={dataView} - filter={ - onFilter - ? (mapping, value, mode) => { - onFilter(mapping, value, mode); - services.toastNotifications.addSuccess( - i18n.translate('discover.grid.flyout.toastFilterAdded', { - defaultMessage: `Filter was added`, - }) - ); - } - : undefined - } + filter={onFilter} onRemoveColumn={(columnName: string) => { onRemoveColumn(columnName); services.toastNotifications.addSuccess( diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index 024fddae01827..83d01cfda77b4 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -2393,7 +2393,6 @@ "discover.grid.flyout.documentNavigation": "Navigation dans le document", "discover.grid.flyout.toastColumnAdded": "La colonne \"{columnName}\" a été ajoutée.", "discover.grid.flyout.toastColumnRemoved": "La colonne \"{columnName}\" a été supprimée.", - "discover.grid.flyout.toastFilterAdded": "Le filtre a été ajouté.", "discover.grid.selectDoc": "Sélectionner le document \"{rowNumber}\"", "discover.grid.tableRow.detailHeading": "Document développé", "discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "Document unique", diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index e9d6170253725..09463397842bf 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -2393,7 +2393,6 @@ "discover.grid.flyout.documentNavigation": "ドキュメントナビゲーション", "discover.grid.flyout.toastColumnAdded": "列'{columnName}'が追加されました", "discover.grid.flyout.toastColumnRemoved": "列'{columnName}'が削除されました", - "discover.grid.flyout.toastFilterAdded": "フィルターが追加されました", "discover.grid.selectDoc": "ドキュメント'{rowNumber}'を選択", "discover.grid.tableRow.detailHeading": "拡張ドキュメント", "discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "1つのドキュメント", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index 795f17050cccb..739c8dabc1c56 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -2393,7 +2393,6 @@ "discover.grid.flyout.documentNavigation": "文档导航", "discover.grid.flyout.toastColumnAdded": "已添加列“{columnName}”", "discover.grid.flyout.toastColumnRemoved": "已移除列“{columnName}”", - "discover.grid.flyout.toastFilterAdded": "已添加筛选", "discover.grid.selectDoc": "选择文档“{rowNumber}”", "discover.grid.tableRow.detailHeading": "已展开文档", "discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "单个文档",