From c2eaa26c53af8ba1c9d1607199f82a7b61bf208a Mon Sep 17 00:00:00 2001
From: Chris Cowan <chris@elastic.co>
Date: Thu, 23 Feb 2023 17:40:19 -0700
Subject: [PATCH] Adding support for negative filter ratios for TSVB

---
 .../lib/vis_data/request_processors/series/filter_ratios.js   | 2 +-
 .../vis_data/request_processors/series/filter_ratios.test.js  | 4 ++--
 .../lib/vis_data/request_processors/table/filter_ratios.ts    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.js b/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.js
index 0aaf011053718..34d933c2e9ae4 100644
--- a/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.js
+++ b/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.js
@@ -62,7 +62,7 @@ export function ratios(req, panel, series, esQueryConfig, seriesIndex) {
               denominator: denominatorPath,
             },
             script:
-              'params.numerator != null && params.denominator != null && params.denominator > 0 ? params.numerator / params.denominator : 0',
+              'params.numerator != null && params.denominator != null && params.denominator != 0 ? params.numerator / params.denominator : 0',
           },
         });
       });
diff --git a/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.test.js b/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.test.js
index a93827ba82cd6..e11414d88fd5c 100644
--- a/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.test.js
+++ b/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/series/filter_ratios.test.js
@@ -73,7 +73,7 @@ describe('ratios(req, panel, series, esQueryConfig, seriesIndex)', () => {
                     },
                     script:
                       'params.numerator != null && params.denominator != null &&' +
-                      ' params.denominator > 0 ? params.numerator / params.denominator : 0',
+                      ' params.denominator != 0 ? params.numerator / params.denominator : 0',
                   },
                 },
                 'metric-1-denominator': {
@@ -150,7 +150,7 @@ describe('ratios(req, panel, series, esQueryConfig, seriesIndex)', () => {
                     },
                     script:
                       'params.numerator != null && params.denominator != null &&' +
-                      ' params.denominator > 0 ? params.numerator / params.denominator : 0',
+                      ' params.denominator != 0 ? params.numerator / params.denominator : 0',
                   },
                 },
                 'metric-1-denominator': {
diff --git a/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/table/filter_ratios.ts b/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/table/filter_ratios.ts
index a897232b27554..3f69c7ec0b99b 100644
--- a/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/table/filter_ratios.ts
+++ b/src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/table/filter_ratios.ts
@@ -63,7 +63,7 @@ export const filterRatios: TableRequestProcessorsFunction = ({
                 denominator: denominatorPath,
               },
               script:
-                'params.numerator != null && params.denominator != null && params.denominator > 0 ? params.numerator / params.denominator : 0',
+                'params.numerator != null && params.denominator != null && params.denominator != 0 ? params.numerator / params.denominator : 0',
             },
           });
         });