From fd1727b2d1e312cb1e2802176563ebd29b2c4ebc Mon Sep 17 00:00:00 2001 From: John Dorlus Date: Fri, 28 Oct 2022 05:52:53 -0400 Subject: [PATCH] Added a describe block for the tests that involve space b. There is an accessibility issue that causes one test to fail and then the subsequent test fails. The issue has been logged. The rest of the tests have been unskipped. --- x-pack/test/accessibility/apps/spaces.ts | 48 ++++++++++++------------ 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/x-pack/test/accessibility/apps/spaces.ts b/x-pack/test/accessibility/apps/spaces.ts index 482429071e3bb..2a4923a15d08c 100644 --- a/x-pack/test/accessibility/apps/spaces.ts +++ b/x-pack/test/accessibility/apps/spaces.ts @@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { const toasts = getService('toasts'); const kibanaServer = getService('kibanaServer'); - // FLAKY: https://github.com/elastic/kibana/issues/137136 - describe.skip('Kibana Spaces Accessibility', () => { + describe('Kibana Spaces Accessibility', () => { before(async () => { await kibanaServer.savedObjects.cleanStandardList(); await PageObjects.common.navigateToApp('home'); @@ -86,29 +85,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { }); // creating space b and making it the current space so space selector page gets displayed when space b gets deleted - // FLAKY: https://github.com/elastic/kibana/issues/135341 - it.skip('a11y test for delete space button', async () => { - await PageObjects.spaceSelector.clickCreateSpace(); - await PageObjects.spaceSelector.clickEnterSpaceName(); - await PageObjects.spaceSelector.addSpaceName('space_b'); - await PageObjects.spaceSelector.clickSaveSpaceCreation(); - await PageObjects.common.navigateToApp('home'); - await PageObjects.spaceSelector.openSpacesNav(); - await PageObjects.spaceSelector.clickSpaceAvatar('space_b'); - await PageObjects.header.waitUntilLoadingHasFinished(); - await PageObjects.spaceSelector.openSpacesNav(); - await PageObjects.spaceSelector.clickManageSpaces(); - await PageObjects.spaceSelector.clickOnDeleteSpaceButton('space_b'); - await a11y.testAppSnapshot(); - }); - - // test starts with deleting space b so we can get the space selection page instead of logging out in the test - it('a11y test for space selection page', async () => { - await PageObjects.spaceSelector.confirmDeletingSpace(); - await retry.try(async () => { + // Skipped due to an a11y violation + // https://github.com/elastic/kibana/issues/144155 + describe.skip('Create Space B and Verify', async () => { + it('a11y test for delete space button', async () => { + await PageObjects.spaceSelector.clickCreateSpace(); + await PageObjects.spaceSelector.clickEnterSpaceName(); + await PageObjects.spaceSelector.addSpaceName('space_b'); + await PageObjects.spaceSelector.clickSaveSpaceCreation(); + await PageObjects.common.navigateToApp('home'); + await PageObjects.spaceSelector.openSpacesNav(); + await PageObjects.spaceSelector.clickSpaceAvatar('space_b'); + await PageObjects.header.waitUntilLoadingHasFinished(); + await PageObjects.spaceSelector.openSpacesNav(); + await PageObjects.spaceSelector.clickManageSpaces(); + await PageObjects.spaceSelector.clickOnDeleteSpaceButton('space_b'); await a11y.testAppSnapshot(); }); - await PageObjects.spaceSelector.clickSpaceCard('default'); + + // test starts with deleting space b so we can get the space selection page instead of logging out in the test + it('a11y test for space selection page', async () => { + await PageObjects.spaceSelector.confirmDeletingSpace(); + await retry.try(async () => { + await a11y.testAppSnapshot(); + }); + await PageObjects.spaceSelector.clickSpaceCard('default'); + }); }); }); }