From ba0f8ffc000faebf6bde4f77091aa181e0efd65f Mon Sep 17 00:00:00 2001 From: CJ Cenizal Date: Thu, 5 Oct 2017 17:57:37 -0700 Subject: [PATCH 01/10] Use h2 elements for titles in Sharing dropdown. --- src/ui/public/share/views/share.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ui/public/share/views/share.html b/src/ui/public/share/views/share.html index fd325c0c08f54..72ea890010a26 100644 --- a/src/ui/public/share/views/share.html +++ b/src/ui/public/share/views/share.html @@ -2,12 +2,12 @@
-
Share saved {{share.objectType}} -
+
@@ -99,9 +99,9 @@
-
+

Share Snapshot -

+
From 35d540f3c53d4d08f06c20a17a560281ddea1059 Mon Sep 17 00:00:00 2001 From: CJ Cenizal Date: Thu, 5 Oct 2017 17:59:03 -0700 Subject: [PATCH 02/10] Override inherited typographic styles in kuiLocalDropdownTitle. --- ui_framework/dist/ui_framework.css | 5 +++++ ui_framework/src/components/local_nav/_local_dropdown.scss | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/ui_framework/dist/ui_framework.css b/ui_framework/dist/ui_framework.css index 83a150fc08bf8..1d7821d65f8fe 100644 --- a/ui_framework/dist/ui_framework.css +++ b/ui_framework/dist/ui_framework.css @@ -1911,7 +1911,12 @@ main { .kuiLocalDropdownPanel--right { margin-left: 30px; } +/** + * 1. Override inherited styles. + */ .kuiLocalDropdownTitle { + margin-top: 0; + /* 1 */ margin-bottom: 12px; font-size: 18px; color: #2d2d2d; } diff --git a/ui_framework/src/components/local_nav/_local_dropdown.scss b/ui_framework/src/components/local_nav/_local_dropdown.scss index 78f2d6c754b8a..042fbe2e84a74 100644 --- a/ui_framework/src/components/local_nav/_local_dropdown.scss +++ b/ui_framework/src/components/local_nav/_local_dropdown.scss @@ -41,7 +41,11 @@ margin-left: 30px; } +/** + * 1. Override inherited styles. + */ .kuiLocalDropdownTitle { + margin-top: 0; /* 1 */ margin-bottom: 12px; font-size: 18px; color: $localNavTextColor; From 208095c7cd73ca3f83a7ac5afa1d7b0e96d16270 Mon Sep 17 00:00:00 2001 From: CJ Cenizal Date: Thu, 5 Oct 2017 18:02:11 -0700 Subject: [PATCH 03/10] Use h2 elements for titles in Console dropdowns. --- src/core_plugins/console/public/src/directives/help.html | 2 +- src/core_plugins/console/public/src/directives/history.html | 2 +- src/core_plugins/console/public/src/directives/settings.html | 2 +- src/core_plugins/console/public/src/directives/welcome.html | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core_plugins/console/public/src/directives/help.html b/src/core_plugins/console/public/src/directives/help.html index 9030f8559b668..5fbb645b095e8 100644 --- a/src/core_plugins/console/public/src/directives/help.html +++ b/src/core_plugins/console/public/src/directives/help.html @@ -1,4 +1,4 @@ -
Help
+

Help

diff --git a/src/core_plugins/console/public/src/directives/history.html b/src/core_plugins/console/public/src/directives/history.html index 120fc615d6a38..630ab2b264578 100644 --- a/src/core_plugins/console/public/src/directives/history.html +++ b/src/core_plugins/console/public/src/directives/history.html @@ -1,4 +1,4 @@ -
History
+

History

    Settings
+

Settings

diff --git a/src/core_plugins/console/public/src/directives/welcome.html b/src/core_plugins/console/public/src/directives/welcome.html index 906c52083bd0b..ed612655eddc2 100644 --- a/src/core_plugins/console/public/src/directives/welcome.html +++ b/src/core_plugins/console/public/src/directives/welcome.html @@ -1,4 +1,4 @@ -
Welcome to Console
+

Welcome to Console

Quick intro to the UI

From 91fdae9f69e43b6f2a34231d77464f3c623680f1 Mon Sep 17 00:00:00 2001 From: CJ Cenizal Date: Fri, 6 Oct 2017 11:36:18 -0700 Subject: [PATCH 04/10] Update kuiLocalDropdownHeader__label class to be applicable to legend elements. --- ui_framework/dist/ui_framework.css | 5 +++++ ui_framework/src/components/local_nav/_local_dropdown.scss | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/ui_framework/dist/ui_framework.css b/ui_framework/dist/ui_framework.css index 1d7821d65f8fe..adde2d719e256 100644 --- a/ui_framework/dist/ui_framework.css +++ b/ui_framework/dist/ui_framework.css @@ -1943,9 +1943,14 @@ main { justify-content: space-between; margin-bottom: 6px; } +/** + * 1. Override inherited styles. + */ .kuiLocalDropdownHeader__label { font-size: 14px; font-weight: 700; + margin-bottom: 0; + /* 1 */ color: #2d2d2d; } .theme-dark .kuiLocalDropdownHeader__label { color: #cecece; } diff --git a/ui_framework/src/components/local_nav/_local_dropdown.scss b/ui_framework/src/components/local_nav/_local_dropdown.scss index 042fbe2e84a74..d1ccc3560c4d6 100644 --- a/ui_framework/src/components/local_nav/_local_dropdown.scss +++ b/ui_framework/src/components/local_nav/_local_dropdown.scss @@ -70,9 +70,13 @@ margin-bottom: 6px; } + /** + * 1. Override inherited styles. + */ .kuiLocalDropdownHeader__label { font-size: 14px; font-weight: 700; + margin-bottom: 0; /* 1 */ color: $localNavTextColor; @include darkTheme { From f1ed13fbedeb5d62437361f91915dd259a614498 Mon Sep 17 00:00:00 2001 From: CJ Cenizal Date: Fri, 6 Oct 2017 11:36:48 -0700 Subject: [PATCH 05/10] Update Console settings menu with aria labeling and UI Framework styles. --- .../public/src/directives/settings.html | 112 +++++++++++------- 1 file changed, 68 insertions(+), 44 deletions(-) diff --git a/src/core_plugins/console/public/src/directives/settings.html b/src/core_plugins/console/public/src/directives/settings.html index be4c46cc7acb4..949fb74f65b8b 100644 --- a/src/core_plugins/console/public/src/directives/settings.html +++ b/src/core_plugins/console/public/src/directives/settings.html @@ -1,67 +1,91 @@

Settings

-
+
-
Font Size
-
- -
- + Font Size +
-
- -
+ -
+ + -
+
-
Autocomplete
-
- -
- + + Autocomplete +
-
- -
+ -
+ + -