-
Notifications
You must be signed in to change notification settings - Fork 8.6k
add API to embed visualizations #14292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3e3da0b
use the time range provided to visualize directive
ppisljar 70e5c23
adding loader function
ppisljar 50379ae
fixing for timelion and tsvb
ppisljar 7914197
loader function should return the element so you can el.on('renderCom…
ppisljar 065c4eb
allow to pass appState and uiState to loader function
ppisljar 655cd24
allowing loader function to work with id as well as saved object
ppisljar 29d11aa
renaming methods on loader object
ppisljar d188026
return a jquery object so we can catch the jquery renderComplete event
ppisljar 10212ea
adding async
ppisljar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import $ from 'jquery'; | ||
|
|
||
| export function VisualizeLoaderProvider($compile, $rootScope, savedVisualizations) { | ||
| const renderVis = (el, savedObj, params) => { | ||
| const scope = $rootScope.$new(); | ||
| scope.savedObj = savedObj; | ||
| scope.appState = params.appState; | ||
| scope.uiState = params.uiState; | ||
| scope.timeRange = params.timeRange; | ||
| scope.showSpyPanel = params.showSpyPanel; | ||
| scope.editorMode = params.editorMode; | ||
|
|
||
| const container = el instanceof $ ? el : $(el); | ||
|
|
||
| container.html(''); | ||
| const visEl = $('<visualize saved-obj="savedObj" app-state="appState" ui-state="uiState" ' + | ||
| 'time-range="timeRange" editor-mode="editorMode" show-spy-panel="showSpyPanel"></visualize>'); | ||
| const visHtml = $compile(visEl)(scope); | ||
| container.html(visHtml); | ||
| return visEl; | ||
| }; | ||
|
|
||
| return { | ||
| embedVisualizationWithId: async (el, savedVisualizationId, params) => { | ||
| return new Promise((resolve) => { | ||
| savedVisualizations.get(savedVisualizationId).then(savedObj => { | ||
| const element = renderVis(el, savedObj, params); | ||
| resolve(element); | ||
| }); | ||
| }); | ||
| }, | ||
| embedVisualizationWithSavedObject: (el, savedObj, params) => { | ||
| return renderVis(el, savedObj, params); | ||
| } | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we return
undefinedinstead. What's the use-case of having client have access to the element?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to be able to listen to renderComplete event