Skip to content

[Fleet] Bulk update agent tags improvements #141376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2022
Merged

[Fleet] Bulk update agent tags improvements #141376

merged 3 commits into from
Sep 23, 2022

Conversation

@juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Sep 22, 2022 •
edited by kibanamachine
Loading

Summary

Fixing #136092

Similarly to force unenroll, added action doc on update tags action, and the corresponding success or error action results. This helps seeing the trace in Agent activity.

To verify:

  • update tags on agents
  • verify that the update tags action shows up in Agent activity

image

Added another improvement to update the selected list of tags immediately if the bulk update tags is async (for >10k agents). This helps to see the result immediately, because on the backend it takes 20-30s for the update tags to be done.

To verify:

  • create >10k agent docs with create_agents script
  • select all agents, apply a tag from the list
  • check that the tag change is immediately visible in the list

Checklist

@juliaElastic juliaElastic requested a review from a team as a code owner September 22, 2022 10:32
@juliaElastic juliaElastic self-assigned this Sep 22, 2022
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 22, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 22, 2022

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Sep 22, 2022
criamico
criamico reviewed Sep 22, 2022
View reviewed changes
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_flyout.tsx Outdated
Copy link
Contributor

@criamico criamico Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, are these strings translated? Is it something that we should do in this context?

Copy link
Contributor Author

@juliaElastic juliaElastic Sep 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using them in a FormattedMessage component here, though it might not be best to translate like this. The challenge is that there is a combination of statuses and action types, so writing them out separately would create about 20 strings.

Copy link
Contributor

@criamico criamico Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. I think that this could be handled in a separate ticket, as it's potentially so complex.

juliaElastic
juliaElastic commented Sep 22, 2022
View reviewed changes
...blic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_flyout.tsx
<FormattedMessage
id="xpack.fleet.agentActivityFlyout.failureDescription"
defaultMessage=" A problem occured during this operation."
defaultMessage=" A problem occurred during this operation."
Copy link
Contributor Author

@juliaElastic juliaElastic Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed spelling #141384

@juliaElastic
Copy link
Contributor Author

juliaElastic commented Sep 22, 2022

@elasticmachine merge upstream

criamico
criamico approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link

kibana-ci commented Sep 22, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 914.0KB 914.3KB +339.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

kpollich
kpollich approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@juliaElastic juliaElastic merged commit 30d5ed5 into elastic:main Sep 23, 2022
@kibanamachine kibanamachine mentioned this pull request Sep 23, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2022
@juliaElastic
[Fleet] Bulk update agent tags improvements (elastic#141376)
f2ac9a6 
* update tags: added action doc and results, updating selected list immediately

* fix tests, fix tag rename and delete

* added unit test

(cherry picked from commit 30d5ed5)
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 23, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 23, 2022
@kibanamachine @juliaElastic
[Fleet] Bulk update agent tags improvements (#141376) (#141563)
5ac1b26 
* update tags: added action doc and results, updating selected list immediately

* fix tests, fix tag rename and delete

* added unit test

(cherry picked from commit 30d5ed5)

Co-authored-by: Julia Bardi <[email protected]>
@juliaElastic juliaElastic mentioned this pull request Sep 26, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpollich kpollich kpollich approved these changes

@criamico criamico criamico approved these changes

Assignees

@juliaElastic juliaElastic

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0 v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@juliaElastic @elasticmachine @kibana-ci @kibanamachine @kpollich @criamico