[Enterprise Search] Do not include precision in the search request when precision tuning is not enabled for an Engine #136670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en precision tuning is not enabled for an Engine
carlosdelest
commented
Jul 20, 2022
| }; | ||
|
|
||
| const searchSettingsWithoutNewBoostProp = { | ||
| const { ['precision_enabled']: precisionEnabled, ...searchSettingsWithoutNewBoostProp } = { |
Member
Author
There was a problem hiding this comment.
Check precision is being sent, but precision_enabled is not
| searchSettings: { | ||
| searchField: {}, | ||
| boosts: {}, | ||
| precision: 7, |
Member
Author
There was a problem hiding this comment.
Check precision being sent to search
| }); | ||
| }); | ||
|
|
||
| it("won't send precision on the API call if it is not enabled", async () => { |
Member
Author
There was a problem hiding this comment.
Add test for precision not being sent
| actions.setResultsLoading(true); | ||
|
|
||
| const filteredBoosts = removeEmptyValueBoosts(boosts); | ||
| const precisionSettings = values.isPrecisionTuningEnabled ? { precision } : {}; |
Member
Author
There was a problem hiding this comment.
Actual fix (thanks @afoucret !): Do not send precision when precision tuning is not enabled
carlosdelest
added
v8.4.0
Team:EnterpriseSearch
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in https://github.com/elastic/enterprise-search-team/issues/2292, precision parameter was being sent in precision tuning search preview when precision tuning was disabled:
Solution is to avoid sending precision parameter to Search API when precision tuning is not enabled.
Checklist