Skip to content

[Security Solution][Exceptions] - Fixes exception builder bug that includes matches operator #136340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 19, 2022
Merged

[Security Solution][Exceptions] - Fixes exception builder bug that includes matches operator #136340

merged 9 commits into from
Jul 19, 2022

Conversation

@yctercero
Copy link
Contributor

@yctercero yctercero commented Jul 13, 2022 •
edited
Loading

Summary

Addresses #136224

Testing

  • Create a rule
  • Go to rule details and add an exception
  • Select a field and check that the "matches" operator is not available

Checklist

@yctercero yctercero added release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform v8.3.0 v8.4.0 labels Jul 13, 2022
@yctercero yctercero self-assigned this Jul 13, 2022
@yctercero yctercero requested a review from a team as a code owner July 13, 2022 19:55
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 13, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero yctercero mentioned this pull request Jul 13, 2022
Closed
@yctercero yctercero enabled auto-merge (squash) July 14, 2022 17:07
@yctercero yctercero added v8.3.3 auto-backport Deprecated - use backport:version if exact versions are needed and removed v8.3.0 labels Jul 14, 2022
@yctercero yctercero requested a review from ashokaditya July 18, 2022 20:32
yctercero
yctercero commented Jul 18, 2022
View reviewed changes
packages/kbn-securitysolution-list-utils/src/autocomplete_operators/index.ts
];


export const ALL_OPERATORS: OperatorOption[] = [
Copy link
Contributor Author

@yctercero yctercero Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed this to try to help with a bit of the confusion.

@yctercero yctercero disabled auto-merge July 18, 2022 22:18
@kibana-ci
Copy link

kibana-ci commented Jul 18, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/securitysolution-list-utils 179 180 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 147.6KB 147.7KB +48.0B
Unknown metric groups

API count

id before after diff
@kbn/securitysolution-list-utils 227 228 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

ashokaditya
ashokaditya approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @yctercero. I tested it out and it works as expected on the Event Filters side. Also, it doesn't show the matches operator for any fields when creating a rule exception.

Note: Given that file.path.text displayed a matches operator also while creating rules before this fix, I'm not sure if users will still expect that behavior going forward. In other words, maybe the matches operator should show if the field is file.path.text regardless of what the listType is?

dhurley14
dhurley14 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yctercero yctercero merged commit ff3853c into elastic:main Jul 19, 2022
kibanamachine pushed a commit that referenced this pull request Jul 19, 2022
@yctercero
[Security Solution][Exceptions] - Fixes exception builder bug that in…
fe70984 
…cludes matches operator (#136340)

## Summary

Addresses Kibana issue #36224

(cherry picked from commit ff3853c)
@kibanamachine kibanamachine mentioned this pull request Jul 19, 2022
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 19, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 19, 2022
@kibanamachine @yctercero
[Security Solution][Exceptions] - Fixes exception builder bug that in…
025bedb 
…cludes matches operator (#136340) (#136652)

## Summary

Addresses Kibana issue #36224

(cherry picked from commit ff3853c)

Co-authored-by: Yara Tercero <[email protected]>
@yctercero yctercero deleted the remove_matches_from_builder branch August 4, 2022 18:30
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

Assignees

@yctercero yctercero

Labels

auto-backport Deprecated - use backport:version if exact versions are needed ci:cloud-deploy Create or update a Cloud deployment release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.3 v8.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yctercero @elasticmachine @kibana-ci @kibanamachine @dhurley14 @ashokaditya @tylersmalley