-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[EBT] Dashboard data loaded event #134243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/plugins/embeddable/public/lib/containers/embeddable_child_panel.tsx
Outdated
Show resolved
Hide resolved
nreese
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-gis changes LGTM
afharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the EBT FTR docs to reflect the changes to the option fromTimestamp 😇
test/analytics/fixtures/plugins/analytics_ftr_helpers/common/fetch_events.ts
Show resolved
Hide resolved
test/analytics/fixtures/plugins/analytics_ftr_helpers/public/plugin.test.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Canvas Sharable Runtime
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @lizozom |
…55885) Fixes #155773 #134243 surfaced layer errors as `output.error`. This was a mistake and caused map embeddable to render only the layer error instead of the map <img width="500" alt="Screen Shot 2023-04-26 at 7 27 00 AM" src="https://user-images.githubusercontent.com/373691/234602920-4d063a4b-bc02-4fac-9037-0774a790b471.png"> PR resolves issue by no longer surfacing layer errors as `output.error`. The map legend does a great job of surfacing individual layer errors and still keeps the map usable. <img width="500" alt="Screen Shot 2023-04-26 at 7 26 42 AM" src="https://user-images.githubusercontent.com/373691/234603008-8c24674f-21ca-4046-88ed-b1f7b5a06b5b.png"> To test * install web log sample data * Add runtime geo point field to data view * create and save map with runtime geo point field. * remove runtime field from data view * add map to dashboard. Verify map is displayed and error is surfaced in map legend --------- Co-authored-by: Kibana Machine <[email protected]>
…astic#155885) Fixes elastic#155773 elastic#134243 surfaced layer errors as `output.error`. This was a mistake and caused map embeddable to render only the layer error instead of the map <img width="500" alt="Screen Shot 2023-04-26 at 7 27 00 AM" src="https://user-images.githubusercontent.com/373691/234602920-4d063a4b-bc02-4fac-9037-0774a790b471.png"> PR resolves issue by no longer surfacing layer errors as `output.error`. The map legend does a great job of surfacing individual layer errors and still keeps the map usable. <img width="500" alt="Screen Shot 2023-04-26 at 7 26 42 AM" src="https://user-images.githubusercontent.com/373691/234603008-8c24674f-21ca-4046-88ed-b1f7b5a06b5b.png"> To test * install web log sample data * Add runtime geo point field to data view * create and save map with runtime geo point field. * remove runtime field from data view * add map to dashboard. Verify map is displayed and error is surfaced in map legend --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 1b64cfa)
Summary
Needed for https://github.com/elastic/kibana-team/issues/501
Depends on #134786
This PR reports a telemetry event each time a dashboard's data is loaded.
It does so by standardizing the
loading,renderedanderrorattributes of theEmbeddableinterface.It also adds a
readonlyproperty namedreportsEmbeddableLoad, to default to immediate rendering, in case theEmbeddabledoesn't implement specific states.Each embeddable sets it output with these attributes
loading- true when loading data, false otherwiserendered- true when the visualization is fully rendered (similar todata-rendercomplete`)error- any error that happened while loading data or renderingEach
embeddable_child_panelreceives an optional callback namedonPanelStatusChange. It is called every time the underlaying embeddable changes it's (relevant) output, containg:status- the current event, statuses are fromEmbeddableRenderStatusid- the embeddable idtimeToEvent- time relative to the component mounterror- if was returned by the embeddableThe
dashboard_gridthen listens to the events coming in from all panels, and when all have completed, it reports a telemetry event that contains:timeToData- the time it took to load the data of all embeddables (Known issue with vector tile maps @nreese)timeToDone- the time it took to render all panelsstatus-okif all loaded successfully,errorotherwise.numOfPanels- number of panels on that dashboardChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers