Skip to content

[Reporting] Fix incorrect number of hits being exported from CSV #112406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Reporting] Fix incorrect number of hits being exported from CSV #112406

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8d4c581
WIP, switched CSV export to use PIT instead of scroll
jloleysens Sep 16, 2021
f202622
remove .skip
jloleysens Sep 16, 2021
198b8f0
Merge branch '7.x' into reporting/csv-export-fix
kibanamachine Sep 16, 2021
e059f08
clean up the generate csv file
jloleysens Sep 16, 2021
4c09af6
re-add username to get query
jloleysens Sep 16, 2021
14582f9
set ignore_unavailable to undefined
jloleysens Sep 16, 2021
7db7614
revert back to using _scroll, unskip the CSV export tests
jloleysens Sep 20, 2021
34ff860
Merge branch '7.x' into reporting/csv-export-fix
kibanamachine Sep 21, 2021
a9fc818
Merge branch '7.x' into reporting/csv-export-fix
kibanamachine Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/discover/reporting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await kibanaServer.uiSettings.update({ 'discover:searchFieldsFromSource': setValue });
};

// Failing: See https://github.com/elastic/kibana/issues/112164
describe.skip('Discover CSV Export', () => {
describe('Discover CSV Export', () => {
before('initialize tests', async () => {
log.debug('ReportingPage:initTests');
await esArchiver.load('x-pack/test/functional/es_archives/reporting/ecommerce');
Expand Down