Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically extend plugin config schema with enabled #61361

Closed
joshdover opened this issue Mar 25, 2020 · 3 comments
Closed

Automatically extend plugin config schema with enabled #61361

joshdover opened this issue Mar 25, 2020 · 3 comments
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Follow up to #60998

We should automatically add the enabled config option to plugin config schemas if they are missing.

Depends on #59083

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Mar 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

pgayvallet commented Jul 6, 2020

We should automatically add the enabled config option to plugin config schemas if they are missing.

The chosen implementation for #59083 do not allow consumers to check if a specific key is present in a given instance of ObjectType, meaning that 'adding a key if not present' is not possible atm.

We would need either direct access to the props property,an API to list the keys of the schema, or any other way to check the 'is key present' condition.

@mshustov
Copy link
Contributor

Already unnecessary, considering #89584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

4 participants