[Maps] Remove number-restriction on feature-ids

[thomasneirynck]

In Maps:

kibana/x-pack/legacy/plugins/maps/public/layers/util/assign_feature_ids.js

Lines 29 to 34 in 8e9a8a8

	for (let i = 0; i < featureCollection.features.length; i++) {
	const id = generateNumericalId();
	ids.push(id);
	}
	const randomizedIds = _.shuffle(ids);

,

All features from a geojson:

• are assigned a numerical id. This was a limitation of mapbox-gl, and required for Maps to be able to assign feature-state to a feature.
• shuffled. This was an ad-hoc workaround to avoid mapbox-gl crashes (Error: RangeError: Maximum call stack size exceeded (potentially due to layer size/count) mapbox/mapbox-gl-js#6086)

Latest mapbox-gl (mapbox/mapbox-gl-js#8987) seems to allow string-ids now. When upgrading, Maps should have this logic removed as both operations were purely to work around limitations of mapbox-gl.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[thomasneirynck]

let's close. can do this when there's a specific need, otherwise this is just a refactor.