Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins can close Elasticsearch clients and break other plugins #48963

Closed
joshdover opened this issue Oct 22, 2019 · 4 comments
Closed

Plugins can close Elasticsearch clients and break other plugins #48963

joshdover opened this issue Oct 22, 2019 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Currently, the clients exposed by the ElasticsearchService in the New Platform are shared instances across all plugins. If one plugin calls the close() method, the client will stop working for all other plugins.

We should probably not expose this method to plugins at all, except in clients exposed via createCluster.

There are no known instances of this at this time, so this is probably low priority or could be fixed when we add the new clients in #35508
@joshdover joshdover added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Oct 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov
Copy link
Contributor

should be prioritized separately from #35508

@mshustov mshustov mentioned this issue Dec 27, 2019
Closed
@pgayvallet
Copy link
Contributor

@restrry I think this has been fixed by #53267?

@mshustov
Copy link
Contributor

@pgayvallet right, closing the current issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pgayvallet @joshdover @mshustov @elasticmachine