Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [PRC Milestone 3] Create rule schema migration method for rule bulk updates #175704

Closed
jpdjere opened this issue Jan 26, 2024 · 4 comments
Closed

[Security Solution] [PRC Milestone 3] Create rule schema migration method for rule bulk updates #175704

jpdjere opened this issue Jan 26, 2024 · 4 comments
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@jpdjere
Copy link
Contributor

jpdjere commented Jan 26, 2024

Prebuilt Rule Customization Epic - Milestone 3: #174168
Main Epic: https://github.com/elastic/security-team/issues/1974 (internal)

Additional Material:
- Milestone 3 - Software Design RFC
- Prebuilt Rules Customization Technical Design

Description:

  • Create the migratePrebuiltSchemaOnRuleBulkEdit method, as described in RFC, that performs rule schema migrations on bulk editing operations of rules.

  • Note that this logic needs to be created and added on the Alerting Framework side.

  • Changes should be backward compatible and should be able to be merged to main or a feature branch.

  • As described in the RFC, this method includes the calculation of the prebuilt.isCustomized field by leveraging the RuleClient's logic that calculates whether the update of a rule was skipped in none of the operations produce an actual change in the rule fields. However, this logic conisders updates to a rule actions as a valid change, which shouldn't be taken into account when calculating prebuilt.isCustomized. Add the logic to be able to differentiate this type of update.
@jpdjere jpdjere added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules labels Jan 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere jpdjere mentioned this issue Jan 26, 2024
Open
@jpdjere
Copy link
Contributor Author

jpdjere commented Apr 9, 2024

Closing in favour of new tickets planned: #174168 (comment)

@jpdjere jpdjere closed this as completed Apr 9, 2024
@banderror banderror closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpdjere @banderror @elasticmachine