Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent Upgrade]: Unable to upgrade agents on latest 8.4 Snapshot and fleet fails to detect correct version of installed agent during upgrade. #139006

Closed
amolnater-qasource opened this issue Aug 11, 2022 · 8 comments · Fixed by #139007
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Elastic-Agent-Control-Plane Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana version: 8.4.0 Snapshot Kibana cloud environment

Host OS: All

Build details:
VERSION: 8.4.0
BUILD: 55248
COMMIT: 62ed40b
Artifact Link: https://artifacts.elastic.co/downloads/beats/elastic-agent/elastic-agent-8.3.0-linux-x86_64.tar.gz

Preconditions:

  1. 8.4.0 Snapshot Kibana cloud environment should be available.
  2. Lower version 8.3.0 agent should be installed.

Integrations:
System

Steps to reproduce:

  1. Navigate to Fleet>Agents tab.
  2. Select Upgrade Agent for lower version agent.
  3. Observe error message cannot upgrade agent to 8.4.0 because it is higher than the installed kibana version 8.4.0 for lower version agent.

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-08-10.19-57-40.mp4

Expected Result:
User should be able to upgrade agents to latest version on 8.4 Snapshot.

@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience Team:Elastic-Agent-Control-Plane Team:Fleet Team label for Observability Data Collection Fleet team impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Aug 11, 2022
@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@AndersonQ
Copy link
Member

@amolnater-qasource do you know if the agent got the update command and rejected it or if the UI itself is preventing the upgrade?

@amolnater-qasource
Copy link
Author

Hi @AndersonQ
Thank you for looking into this.
From the agent logs we have observed that Upgrade command is never delivered to the agent. However, it seems the case is UI itself is preventing the upgrade.

Further we have also observed that this issue still reproducible on latest 8.4 Snapshot.

Screenshots:
8
9

Build details:
BUILD: 55338
COMMIT: f56b2ce

Please let us know if anything else is required from our end.

Thanks

@jlind23
Copy link
Contributor

jlind23 commented Aug 17, 2022

Thanks @amolnater-qasource this error message seems to be a Kibana one. Maybe @kpollich and @elastic/fleet may be able to help here.

@juliaElastic
Copy link
Contributor

We found the problem in kibana logic, the code doesn’t compare versions correctly, should be comparing the coerced versions: semverGt(versionToUpgradeNumber, kibanaVersionNumber)
https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/routes/agent/upgrade_handler.ts#L163
This issue can be transferred to kibana repo.

@juliaElastic juliaElastic self-assigned this Aug 17, 2022
@juliaElastic juliaElastic transferred this issue from elastic/elastic-agent Aug 17, 2022
@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Aug 18, 2022
@amolnater-qasource
Copy link
Author

Hi @juliaElastic
We have revalidated this issue on latest 8.4 Snapshot and found it fixed now.

Observations:

  • User is able to trigger upgrade agents to latest version on 8.4.
  • No same version agent error is available.

Build details:
VERSION: 8.4.0 Snapshot
BUILD: 55395
COMMIT: 1922ab0

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-08-22.10-20-09.mp4

Hence marking this as QA:Validated.

Thanks

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Aug 22, 2022
@amolnater-qasource
Copy link
Author

Bug Conversion

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Elastic-Agent-Control-Plane Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants