Skip to content

Commit fa0c796

Browse files
Fix alert defaults (#81207) (#81380)
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
1 parent 70c73ff commit fa0c796

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

x-pack/plugins/monitoring/server/alerts/disk_usage_alert.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('DiskUsageAlert', () => {
3636
expect(alert.type).toBe(ALERT_DISK_USAGE);
3737
expect(alert.label).toBe('Disk Usage');
3838
expect(alert.defaultThrottle).toBe('1d');
39-
expect(alert.defaultParams).toStrictEqual({ threshold: 90, duration: '5m' });
39+
expect(alert.defaultParams).toStrictEqual({ threshold: 80, duration: '5m' });
4040
expect(alert.actionVariables).toStrictEqual([
4141
{ name: 'nodes', description: 'The list of nodes reporting high disk usage.' },
4242
{ name: 'count', description: 'The number of nodes reporting high disk usage.' },

x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class DiskUsageAlert extends BaseAlert {
5454
public label = DiskUsageAlert.LABEL;
5555

5656
protected defaultParams = {
57-
threshold: 90,
57+
threshold: 80,
5858
duration: '5m',
5959
};
6060

x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ describe('MissingMonitoringDataAlert', () => {
2222
const alert = new MissingMonitoringDataAlert();
2323
expect(alert.type).toBe(ALERT_MISSING_MONITORING_DATA);
2424
expect(alert.label).toBe('Missing monitoring data');
25-
expect(alert.defaultThrottle).toBe('1d');
25+
expect(alert.defaultThrottle).toBe('6h');
2626
// @ts-ignore
27-
expect(alert.defaultParams).toStrictEqual({ limit: '1d', duration: '5m' });
27+
expect(alert.defaultParams).toStrictEqual({ limit: '1d', duration: '15m' });
2828
// @ts-ignore
2929
expect(alert.actionVariables).toStrictEqual([
3030
{ name: 'stackProducts', description: 'The stack products missing monitoring data.' },

x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const FIRING = i18n.translate('xpack.monitoring.alerts.missingData.firing', {
5050
defaultMessage: 'firing',
5151
});
5252

53-
const DEFAULT_DURATION = '5m';
53+
const DEFAULT_DURATION = '15m';
5454
const DEFAULT_LIMIT = '1d';
5555

5656
// Go a bit farther back because we need to detect the difference between seeing the monitoring data versus just not looking far enough back
@@ -77,6 +77,8 @@ export class MissingMonitoringDataAlert extends BaseAlert {
7777
} as CommonAlertParamDetail,
7878
};
7979

80+
public defaultThrottle: string = '6h';
81+
8082
public type = ALERT_MISSING_MONITORING_DATA;
8183
public label = i18n.translate('xpack.monitoring.alerts.missingData.label', {
8284
defaultMessage: 'Missing monitoring data',

0 commit comments

Comments
 (0)