Skip to content

Commit f6c44df

Browse files
authored
[Uptime] Feature/expandable row in details ping list (#51890)
* update columns * update expand row in ping list
1 parent c4e4da3 commit f6c44df

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ export const MonitorListComponent = (props: Props) => {
208208
field: 'monitor_id',
209209
name: '',
210210
sortable: true,
211-
width: '40px',
211+
width: '24px',
212212
isExpander: true,
213213
render: (id: string) => {
214214
return (

x-pack/legacy/plugins/uptime/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ export const PingListComponent = ({
190190
if (hasStatus) {
191191
columns.push({
192192
field: 'http.response.status_code',
193-
align: 'right',
193+
align: 'center',
194194
name: i18n.translate('xpack.uptime.pingList.responseCodeColumnLabel', {
195195
defaultMessage: 'Response code',
196196
}),
@@ -200,7 +200,7 @@ export const PingListComponent = ({
200200

201201
columns.push({
202202
align: 'right',
203-
width: '40px',
203+
width: '24px',
204204
isExpander: true,
205205
render: (item: Ping) => (
206206
<EuiButtonIcon
@@ -300,6 +300,8 @@ export const PingListComponent = ({
300300
<EuiBasicTable
301301
loading={loading}
302302
columns={columns}
303+
isExpandable={true}
304+
hasActions={true}
303305
items={pings}
304306
itemId="id"
305307
itemIdToExpandedRowMap={itemIdToExpandedRowMap}

0 commit comments

Comments
 (0)