Skip to content

Commit f4969e7

Browse files
committed
Merge remote-tracking branch upstream/master
2 parents efa68c2 + 183cf56 commit f4969e7

File tree

1,306 files changed

+26958
-13265
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,306 files changed

+26958
-13265
lines changed

.ci/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
22
# If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
33

4-
ARG NODE_VERSION=14.15.3
4+
ARG NODE_VERSION=14.15.4
55

66
FROM node:${NODE_VERSION} AS base
77

docs/developer/advanced/index.asciidoc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,12 @@
44
* <<running-elasticsearch>>
55
* <<development-es-snapshots>>
66
* <<development-basepath>>
7+
* <<upgrading-nodejs>>
78

89
include::development-es-snapshots.asciidoc[leveloffset=+1]
910

1011
include::running-elasticsearch.asciidoc[leveloffset=+1]
1112

12-
include::development-basepath.asciidoc[leveloffset=+1]
13+
include::development-basepath.asciidoc[leveloffset=+1]
14+
15+
include::upgrading-nodejs.asciidoc[leveloffset=+1]
Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
[[upgrading-nodejs]]
2+
== Upgrading Node.js
3+
4+
{kib} requires a specific Node.js version to run.
5+
When running {kib} from source, you must have this version installed locally.
6+
7+
The required version of Node.js is listed in several different files throughout the {kib} source code.
8+
Theses files must be updated when upgrading Node.js:
9+
10+
- {kib-repo}blob/{branch}/.ci/Dockerfile[`.ci/Dockerfile`] - The version is specified in the `NODE_VERSION` constant.
11+
This is used to pull the relevant image from https://hub.docker.com/_/node[Docker Hub].
12+
Note that Docker Hub can take 24+ hours to be updated with the new images after a new release of Node.js, so if you're upgrading Node.js in Kibana _just_ after the official Node.js release, you have to check if the new images are present on Docker Hub.
13+
If they are not, and the update is urgent, you can skip this file and update it later once Docker Hub has been updated.
14+
- {kib-repo}blob/{branch}/.node-version[`.node-version`]
15+
- {kib-repo}blob/{branch}/.nvmrc[`.nvmrc`]
16+
- {kib-repo}blob/{branch}/package.json[`package.json`] - The version is specified in the `engines.node` field.
17+
18+
See PR {kib-repo}pull/86593[#86593] for an example of how the Node.js version has been upgraded previously.
19+
20+
In the 6.8 branch, the `.ci/Dockerfile` file does not exist, so when upgrading Node.js in that branch, just skip that file.
21+
22+
=== Backporting
23+
24+
The following rules are not set in stone.
25+
Use best judgement when backporting.
26+
27+
Currently version 7.11 and newer run Node.js 14, while 7.10 and older run Node.js 10.
28+
Hence, upgrades to either Node.js 14 or Node.js 10 shold be done as separate PRs.
29+
30+
==== Node.js patch upgrades
31+
32+
Typically, you want to backport Node.js *patch* upgrades to all supported release branches that run the same _major_ Node.js version:
33+
34+
- If upgrading Node.js 14, and the current release is 7.11.1, the main PR should target `master` and be backported to `7.x` and `7.11`.
35+
- If upgrading Node.js 10, the main PR should target `6.8` only.
36+
37+
==== Node.js minor upgrades
38+
39+
Typically, you want to backport Node.js *minor* upgrades to the next minor {kib} release branch that runs the same *major* Node.js version:
40+
41+
- If upgrading Node.js 14, and the current release is 7.11.1, the main PR should target `master` and be backported to `7.x`, while leaving the `7.11` branch as-is.
42+
- If upgrading Node.js 10, the main PR should target `6.8` only.
43+
44+
=== Upgrading installed Node.js version
45+
46+
The following instructions expect that https://github.com/nvm-sh/nvm[nvm] is used to manage locally installed Node.js versions.
47+
48+
Run the following to install the new Node.js version. Replace `<version>` with the desired Node.js version:
49+
50+
[source,bash]
51+
----
52+
nvm install <version>
53+
----
54+
55+
To get the same global npm modules installed with the new version of Node.js as is currently installed, use the `--reinstall-packages-from` command-line argument (optionally replace `14` with the desired source version):
56+
57+
[source,bash]
58+
----
59+
nvm install <version> --reinstall-packages-from=14
60+
----
61+
62+
If needed, uninstall the old version of Node.js by running the following. Replace `<old-version>` with the full version number of the version that should be uninstalled:
63+
64+
[source,bash]
65+
----
66+
nvm uninstall <old-version>
67+
----
68+
69+
Optionally, tell nvm to always use the "highest" installed Node.js 14 version. Replace `14` if a different major version is desired:
70+
71+
[source,bash]
72+
----
73+
nvm alias default 14
74+
----
75+
76+
Alternatively, include the full version number at the end to specify a specific default version.

docs/developer/getting-started/index.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ cd kibana
2020

2121
Install the version of Node.js listed in the `.node-version` file. This
2222
can be automated with tools such as
23-
https://github.com/creationix/nvm[nvm],
23+
https://github.com/nvm-sh/nvm[nvm],
2424
https://github.com/coreybutler/nvm-windows[nvm-windows] or
2525
https://github.com/wbyoung/avn[avn]. As we also include a `.nvmrc` file
2626
you can switch to the correct version when using nvm by running:

docs/developer/plugin-list.asciidoc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,10 @@ Content is fetched from the remote (https://feeds.elastic.co and https://feeds-s
168168
|Create choropleth maps. Display the results of a term-aggregation as e.g. countries, zip-codes, states.
169169
170170
171+
|{kib-repo}blob/{branch}/src/plugins/runtime_fields/README.mdx[runtimeFields]
172+
|The runtime fields plugin provides types and constants for OSS and xpack runtime field related code.
173+
174+
171175
|{kib-repo}blob/{branch}/src/plugins/saved_objects/README.md[savedObjects]
172176
|The savedObjects plugin exposes utilities to manipulate saved objects on the client side.
173177
@@ -483,8 +487,8 @@ Elastic.
483487
|Welcome to the Kibana rollup plugin! This plugin provides Kibana support for Elasticsearch's rollup feature. Please refer to the Elasticsearch documentation to understand rollup indices and how to create rollup jobs.
484488
485489
486-
|{kib-repo}blob/{branch}/x-pack/plugins/runtime_fields/README.md[runtimeFields]
487-
|Welcome to the home of the runtime field editor and everything related to runtime fields!
490+
|{kib-repo}blob/{branch}/x-pack/plugins/runtime_field_editor/README.md[runtimeFieldEditor]
491+
|Welcome to the home of the runtime field editor!
488492
489493
490494
|{kib-repo}blob/{branch}/x-pack/plugins/saved_objects_tagging/README.md[savedObjectsTagging]

docs/development/core/public/kibana-plugin-core-public.doclinksstart.links.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ readonly links: {
1515
readonly urlDrilldownTemplateSyntax: string;
1616
readonly urlDrilldownVariables: string;
1717
};
18+
readonly discover: Record<string, string>;
1819
readonly filebeat: {
1920
readonly base: string;
2021
readonly installation: string;

docs/development/core/public/kibana-plugin-core-public.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
114114
| [SavedObjectsFindResponsePublic](./kibana-plugin-core-public.savedobjectsfindresponsepublic.md) | Return type of the Saved Objects <code>find()</code> method.<!-- -->\*Note\*: this type is different between the Public and Server Saved Objects clients. |
115115
| [SavedObjectsImportAmbiguousConflictError](./kibana-plugin-core-public.savedobjectsimportambiguousconflicterror.md) | Represents a failure to import due to a conflict, which can be resolved in different ways with an overwrite. |
116116
| [SavedObjectsImportConflictError](./kibana-plugin-core-public.savedobjectsimportconflicterror.md) | Represents a failure to import due to a conflict. |
117-
| [SavedObjectsImportError](./kibana-plugin-core-public.savedobjectsimporterror.md) | Represents a failure to import. |
117+
| [SavedObjectsImportFailure](./kibana-plugin-core-public.savedobjectsimportfailure.md) | Represents a failure to import. |
118118
| [SavedObjectsImportMissingReferencesError](./kibana-plugin-core-public.savedobjectsimportmissingreferenceserror.md) | Represents a failure to import due to missing references. |
119119
| [SavedObjectsImportResponse](./kibana-plugin-core-public.savedobjectsimportresponse.md) | The response describing the result of an import. |
120120
| [SavedObjectsImportRetry](./kibana-plugin-core-public.savedobjectsimportretry.md) | Describes a retry operation for importing a saved object. |

docs/development/core/public/kibana-plugin-core-public.savedobjectsimporterror.id.md

Lines changed: 0 additions & 11 deletions
This file was deleted.

docs/development/core/public/kibana-plugin-core-public.savedobjectsimporterror.md

Lines changed: 0 additions & 25 deletions
This file was deleted.

docs/development/core/public/kibana-plugin-core-public.savedobjectsimporterror.type.md

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)