Skip to content

Commit f36b044

Browse files
[7.x] [Metrics UI] Fix Alert Preview Error design (#71005) (#72499)
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
1 parent 1918f37 commit f36b044

File tree

1 file changed

+25
-33
lines changed

1 file changed

+25
-33
lines changed

x-pack/plugins/infra/public/alerting/common/components/alert_preview.tsx

Lines changed: 25 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,9 @@ import {
1414
EuiFlexGroup,
1515
EuiFlexItem,
1616
EuiCallOut,
17-
EuiOverlayMask,
18-
EuiModal,
19-
EuiModalHeader,
20-
EuiModalHeaderTitle,
21-
EuiModalBody,
17+
EuiAccordion,
2218
EuiCodeBlock,
23-
EuiLink,
19+
EuiText,
2420
} from '@elastic/eui';
2521
import { FormattedMessage } from '@kbn/i18n/react';
2622
import { i18n } from '@kbn/i18n';
@@ -61,9 +57,6 @@ export const AlertPreview: React.FC<Props> = (props) => {
6157
const [previewResult, setPreviewResult] = useState<
6258
(AlertPreviewSuccessResponsePayload & Record<string, any>) | null
6359
>(null);
64-
const [isErrorModalVisible, setIsErrorModalVisible] = useState<boolean>(false);
65-
const onOpenModal = useCallback(() => setIsErrorModalVisible(true), [setIsErrorModalVisible]);
66-
const onCloseModal = useCallback(() => setIsErrorModalVisible(false), [setIsErrorModalVisible]);
6760

6861
const onSelectPreviewLookbackInterval = useCallback((e) => {
6962
setPreviewLookbackInterval(e.target.value);
@@ -271,33 +264,32 @@ export const AlertPreview: React.FC<Props> = (props) => {
271264
iconType="alert"
272265
>
273266
{previewError.body && (
274-
<FormattedMessage
275-
id="xpack.infra.metrics.alertFlyout.alertPreviewErrorDesc"
276-
defaultMessage="Try again later, or {viewTheError}."
277-
values={{
278-
viewTheError: <EuiLink onClick={onOpenModal}>view the error</EuiLink>,
279-
}}
280-
/>
267+
<>
268+
<FormattedMessage
269+
id="xpack.infra.metrics.alertFlyout.alertPreviewErrorDesc"
270+
defaultMessage="Please try again later or see details for more information."
271+
/>
272+
<EuiSpacer size={'s'} />
273+
<EuiAccordion
274+
id="alertErrorDetailsAccordion"
275+
buttonContent={
276+
<>
277+
<EuiText size="s">
278+
<FormattedMessage
279+
id="xpack.infra.metrics.alertFlyout.errorDetails"
280+
defaultMessage="Details"
281+
/>
282+
</EuiText>
283+
</>
284+
}
285+
>
286+
<EuiSpacer size={'s'} />
287+
<EuiCodeBlock>{previewError.body.message}</EuiCodeBlock>
288+
</EuiAccordion>
289+
</>
281290
)}
282291
</EuiCallOut>
283292
)}
284-
{isErrorModalVisible && (
285-
<EuiOverlayMask>
286-
<EuiModal onClose={onCloseModal}>
287-
<EuiModalHeader>
288-
<EuiModalHeaderTitle>
289-
<FormattedMessage
290-
id="xpack.infra.metrics.alertFlyout.alertPreviewErrorModalTitle"
291-
defaultMessage="Alert preview error"
292-
/>
293-
</EuiModalHeaderTitle>
294-
</EuiModalHeader>
295-
<EuiModalBody>
296-
<EuiCodeBlock>{previewError.body.message}</EuiCodeBlock>
297-
</EuiModalBody>
298-
</EuiModal>
299-
</EuiOverlayMask>
300-
)}
301293
</>
302294
)}
303295
</>

0 commit comments

Comments
 (0)