Skip to content

Commit f2615c2

Browse files
[SIEM][Detection Engine] Removes deprecated keys from configuration
## Summary Removes deprecated keys from configuration since the backend gives out where the index is located and it is based on spaces. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~ ~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ ~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ ~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~ ~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers ~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~ ~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
1 parent b91b123 commit f2615c2

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

x-pack/legacy/plugins/siem/common/constants.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ export const DEFAULT_TIME_RANGE = 'timepicker:timeDefaults';
1616
export const DEFAULT_REFRESH_RATE_INTERVAL = 'timepicker:refreshIntervalDefaults';
1717
export const DEFAULT_SIEM_TIME_RANGE = 'siem:timeDefaults';
1818
export const DEFAULT_SIEM_REFRESH_INTERVAL = 'siem:refreshIntervalDefaults';
19-
20-
// DEPRECATED: THIS WILL BE REMOVED VERY SOON AND IS NO LONGER USED ON THE BACKEND
21-
// TODO: Remove this as soon as no code is left that is pulling data from it.
22-
export const DEFAULT_SIGNALS_INDEX_KEY = 'siem:defaultSignalsIndex';
23-
2419
export const DEFAULT_SIGNALS_INDEX = '.siem-signals';
2520
export const DEFAULT_MAX_SIGNALS = 100;
2621
export const DEFAULT_SEARCH_AFTER_PAGE_SIZE = 100;

x-pack/legacy/plugins/siem/index.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import {
2626
DEFAULT_TO,
2727
DEFAULT_SIGNALS_INDEX,
2828
SIGNALS_INDEX_KEY,
29-
DEFAULT_SIGNALS_INDEX_KEY,
3029
} from './common/constants';
3130
import { defaultIndexPattern } from './default_index_pattern';
3231
import { initServerWithKibana } from './server/kibana.index';
@@ -106,20 +105,6 @@ export const siem = (kibana: any) => {
106105
category: ['siem'],
107106
requiresPageReload: true,
108107
},
109-
// DEPRECATED: This should be removed once the front end is no longer using any parts of it.
110-
// TODO: Remove this as soon as no code is left that is pulling data from it.
111-
[DEFAULT_SIGNALS_INDEX_KEY]: {
112-
name: i18n.translate('xpack.siem.uiSettings.defaultSignalsIndexLabel', {
113-
defaultMessage: 'Elasticsearch signals index',
114-
}),
115-
value: DEFAULT_SIGNALS_INDEX,
116-
description: i18n.translate('xpack.siem.uiSettings.defaultSignalsIndexDescription', {
117-
defaultMessage:
118-
'<p>Elasticsearch signals index from which outputted signals will appear by default</p>',
119-
}),
120-
category: ['siem'],
121-
requiresPageReload: true,
122-
},
123108
[DEFAULT_ANOMALY_SCORE]: {
124109
name: i18n.translate('xpack.siem.uiSettings.defaultAnomalyScoreLabel', {
125110
defaultMessage: 'Anomaly threshold',

0 commit comments

Comments
 (0)