[Security Solution] Fix networkTopNFlow search strategy response (#80362) (#80582)

Author: patrykkopycinski

x-pack/plugins/security_solution/common/ecs/geo/index.ts

@@ -6,22 +6,15 @@
 
 export interface GeoEcs {
   city_name?: string[];
-
   continent_name?: string[];
-
   country_iso_code?: string[];
-
   country_name?: string[];
-
   location?: Location;
-
   region_iso_code?: string[];
-
   region_name?: string[];
 }
 
 export interface Location {
   lon?: number[];
-
   lat?: number[];
 }

x-pack/plugins/security_solution/common/ecs/source/index.ts

@@ -8,14 +8,9 @@ import { GeoEcs } from '../geo';
 
 export interface SourceEcs {
   bytes?: number[];
-
   ip?: string[];
-
   port?: number[];
-
   domain?: string[];
-
   geo?: GeoEcs;
-
   packets?: number[];
 }

x-pack/plugins/security_solution/public/common/components/tables/__snapshots__/helpers.test.tsx.snap

@@ -12,7 +12,7 @@ import styled from 'styled-components';
 import { DragEffects, DraggableWrapper } from '../drag_and_drop/draggable_wrapper';
 import { escapeDataProviderId } from '../drag_and_drop/helpers';
 import { defaultToEmptyTag, getEmptyTagValue } from '../empty_value';
-import { MoreRowItems, Spacer } from '../page';
+import { MoreRowItems } from '../page';
 import { IS_OPERATOR } from '../../../timelines/components/timeline/data_providers/data_provider';
 import { Provider } from '../../../timelines/components/timeline/data_providers/provider';
 
@@ -92,12 +92,6 @@ export const getRowItemDraggables = ({
       const id = escapeDataProviderId(`${idPrefix}-${attrName}-${rowItem}-${index}`);
       return (
         <React.Fragment key={id}>
-          {index !== 0 && (
-            <>
-              {','}
-              <Spacer />
-            </>
-          )}
           <DraggableWrapper
             key={id}
             dataProvider={{

x-pack/plugins/security_solution/public/common/components/tables/helpers.tsx

@@ -29,6 +29,7 @@ const AnomaliesQueryTabBodyComponent: React.FC<AnomaliesQueryTabBodyProps> = ({
   AnomaliesTableComponent,
   flowTarget,
   ip,
+  hostName,
   indexNames,
 }) => {
   const { jobs } = useInstalledSecurityJobs();
@@ -71,6 +72,7 @@ const AnomaliesQueryTabBodyComponent: React.FC<AnomaliesQueryTabBodyProps> = ({
         narrowDateRange={narrowDateRange}
         flowTarget={flowTarget}
         ip={ip}
+        hostName={hostName}
       />
     </>
   );

x-pack/plugins/security_solution/public/common/containers/anomalies/anomalies_query_tab_body/index.tsx

@@ -32,4 +32,5 @@ export type AnomaliesQueryTabBodyProps = QueryTabBodyProps & {
   updateDateRange?: UpdateDateRange;
   hideHistogramIfEmpty?: boolean;
   ip?: string;
+  hostName?: string;
 };

x-pack/plugins/security_solution/public/common/containers/anomalies/anomalies_query_tab_body/types.ts

@@ -256,12 +256,7 @@ const getAuthenticationColumns = (): AuthTableColumns => [
     hideForMobile: false,
     render: ({ node }) =>
       getRowItemDraggables({
-        rowItems:
-          node.lastSuccess != null &&
-          node.lastSuccess.source != null &&
-          node.lastSuccess.source.ip != null
-            ? node.lastSuccess.source.ip
-            : null,
+        rowItems: node.lastSuccess?.source?.ip || null,
         attrName: 'source.ip',
         idPrefix: `authentications-table-${node._id}-lastSuccessSource`,
         render: (item) => <NetworkDetailsLink ip={item} />,
@@ -273,12 +268,7 @@ const getAuthenticationColumns = (): AuthTableColumns => [
     hideForMobile: false,
     render: ({ node }) =>
       getRowItemDraggables({
-        rowItems:
-          node.lastSuccess != null &&
-          node.lastSuccess.host != null &&
-          node.lastSuccess.host.name != null
-            ? node.lastSuccess.host.name
-            : null,
+        rowItems: node.lastSuccess?.host?.name ?? null,
         attrName: 'host.name',
         idPrefix: `authentications-table-${node._id}-lastSuccessfulDestination`,
         render: (item) => <HostDetailsLink hostName={item} />,
@@ -301,12 +291,7 @@ const getAuthenticationColumns = (): AuthTableColumns => [
     hideForMobile: false,
     render: ({ node }) =>
       getRowItemDraggables({
-        rowItems:
-          node.lastFailure != null &&
-          node.lastFailure.source != null &&
-          node.lastFailure.source.ip != null
-            ? node.lastFailure.source.ip
-            : null,
+        rowItems: node.lastFailure?.source?.ip || null,
         attrName: 'source.ip',
         idPrefix: `authentications-table-${node._id}-lastFailureSource`,
         render: (item) => <NetworkDetailsLink ip={item} />,
@@ -318,12 +303,7 @@ const getAuthenticationColumns = (): AuthTableColumns => [
     hideForMobile: false,
     render: ({ node }) =>
       getRowItemDraggables({
-        rowItems:
-          node.lastFailure != null &&
-          node.lastFailure.host != null &&
-          node.lastFailure.host.name != null
-            ? node.lastFailure.host.name
-            : null,
+        rowItems: node.lastFailure?.host?.name || null,
         attrName: 'host.name',
         idPrefix: `authentications-table-${node._id}-lastFailureDestination`,
         render: (item) => <HostDetailsLink hostName={item} />,

x-pack/plugins/security_solution/public/hosts/components/authentications_table/index.tsx

@@ -129,7 +129,7 @@ describe('Uncommon Process Table Component', () => {
       );
 
       expect(wrapper.find('.euiTableRow').at(2).find('.euiTableRowCell').at(3).text()).toBe(
-        'Host nameshello-world,hello-world-2 '
+        'Host nameshello-worldhello-world-2 '
       );
     });
 
@@ -214,7 +214,7 @@ describe('Uncommon Process Table Component', () => {
         </TestProviders>
       );
       expect(wrapper.find('.euiTableRow').at(4).find('.euiTableRowCell').at(3).text()).toBe(
-        'Host nameshello-world,hello-world-2 '
+        'Host nameshello-worldhello-world-2 '
       );
     });
   });

x-pack/plugins/security_solution/public/hosts/components/uncommon_process_table/index.test.tsx

@@ -198,15 +198,13 @@ export const EmbeddedMapComponent = ({
     if (embeddable != null) {
       embeddable.updateInput({ query });
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [query]);
+  }, [embeddable, query]);
 
   useEffect(() => {
     if (embeddable != null) {
       embeddable.updateInput({ filters });
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [filters]);
+  }, [embeddable, filters]);
 
   // DateRange updated useEffect
   useEffect(() => {
@@ -217,8 +215,7 @@ export const EmbeddedMapComponent = ({
       };
       embeddable.updateInput({ timeRange });
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [startDate, endDate]);
+  }, [embeddable, startDate, endDate]);
 
   return isError ? null : (
     <Embeddable>