chore(19502): change license checker and generator behaviour to only add dev dependencies with --dev flag. (#19626) (#19825)

Author: mistic

package.json

@@ -54,7 +54,7 @@
     "test:ui:runner": "echo 'use `node scripts/functional_test_runner`' && false",
     "test:server": "grunt test:server",
     "test:coverage": "grunt test:coverage",
-    "checkLicenses": "grunt licenses",
+    "checkLicenses": "grunt licenses --dev",
     "build": "node scripts/build",
     "start": "sh ./bin/kibana --dev",
     "precommit": "node scripts/precommit_hook",

tasks/licenses.js

@@ -29,10 +29,13 @@ export default function licenses(grunt) {
     const done = this.async();
 
     try {
+      const dev = Boolean(grunt.option('dev'));
+
       assertLicensesValid({
         packages: await getInstalledPackages({
           directory: grunt.config.get('root'),
-          licenseOverrides: LICENSE_OVERRIDES
+          licenseOverrides: LICENSE_OVERRIDES,
+          dev
         }),
         validLicenses: LICENSE_WHITELIST
       });

tasks/licenses_csv_report.js

@@ -59,12 +59,12 @@ export default function licensesCSVReport(grunt) {
     try {
       const file = grunt.option('csv');
       const directory = grunt.option('directory');
-      const release = Boolean(grunt.option('release'));
+      const dev = Boolean(grunt.option('dev'));
 
       const packages = await getInstalledPackages({
         directory: directory ? resolve(directory) : grunt.config.get('root'),
         licenseOverrides: LICENSE_OVERRIDES,
-        dev: !release
+        dev
       });
 
       const csv = packages.map(pkg => {