Skip to content

Commit e9a7736

Browse files
committed
only register drops if keyboardMode
1 parent 1058db3 commit e9a7736

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

x-pack/plugins/lens/public/drag_drop/drag_drop.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ interface DragInnerProps extends BaseProps {
104104
setActiveDropTarget: DragContextState['setActiveDropTarget'];
105105
setA11yMessage: DragContextState['setA11yMessage'];
106106
activeDraggingProps?: {
107-
keyboardMode: boolean;
107+
keyboardMode: DragContextState['keyboardMode'];
108108
activeDropTarget: DragContextState['activeDropTarget'];
109109
dropTargetsByOrder: DragContextState['dropTargetsByOrder'];
110110
};
@@ -123,6 +123,7 @@ interface DragInnerProps extends BaseProps {
123123
*/
124124
interface DropInnerProps extends BaseProps {
125125
dragging: DragContextState['dragging'];
126+
keyboardMode: DragContextState['keyboardMode'];
126127
setKeyboardMode: DragContextState['setKeyboardMode'];
127128
setDragging: DragContextState['setDragging'];
128129
setActiveDropTarget: DragContextState['setActiveDropTarget'];
@@ -387,19 +388,20 @@ const DropInner = memo(function DropInner(props: DropInnerProps) {
387388
isActiveDropTarget,
388389
registerDropTarget,
389390
setActiveDropTarget,
391+
keyboardMode,
390392
setKeyboardMode,
391393
setDragging,
392394
setA11yMessage,
393395
} = props;
394396

395397
useShallowCompareEffect(() => {
396-
if (dropType && value && onDrop) {
398+
if (dropType && onDrop && keyboardMode) {
397399
registerDropTarget(order, { ...value, onDrop, dropType });
398400
return () => {
399401
registerDropTarget(order, undefined);
400402
};
401403
}
402-
}, [order, value, registerDropTarget, dropType]);
404+
}, [order, value, registerDropTarget, dropType, keyboardMode]);
403405

404406
const classesOnEnter = getAdditionalClassesOnEnter?.(dropType);
405407
const classesOnDroppable = getAdditionalClassesOnDroppable?.(dropType);

0 commit comments

Comments
 (0)