You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Workplace Search] Migrate SourceLogic from ent-search (#83593)
* Initial copy/paste of source logic
Only changed lodash imports and import order for linting
* Add types and route
* Update paths and typings
Renamed IMeta -> Meta
Used object instead of IObject
* Remove internal flash messages in favor of globals
- All instances of flashAPIErrors(e) are only placeholders until the later commit removing axios.
- buttonLoading was set to false when the error flash messages were set. For now I added a `setButtonNotLoading` action to do this manually in a finally block. This will be refactored once axios is removed.
- SourcesLogic is no longer needed because we set a queued flash message instead of trying to set it in SourcesLogic, which no longer has local flash messages
* Add return types to callback definitions
* Update routes
According to the API info getSourceReConnectData is supposed to send the source ID and not the service type. In the template, we are actually sending the ID but the logic file parameterizes it as serviceType. This is fixed here.
Usage: https://github.com/elastic/ent-search/blob/master/app/javascript/workplace_search/ContentSources/components/AddSource/ReAuthenticate.tsx#L38
* Replace axios with HttpLogic
Also removes using history in favor of KibanaLogic’s navigateToUrl
* Fix incorrect type
This selector is actually an array of strings
* Create GenericObject to satisfy TypeScript
Previously in `ent-search`, we had a generic `IObject` interface that we could use on keyed objects. It was not migrated over since it uses `any` and Kibana has a generic `object` type we can use in most situations. However, when we are checking for keys in our code, `object` does not work. This commit is an attempt at making a generic interface we can use.
* More strict object typing
Removes GenericObject from last commit and adds stricter local typing
* Add i18n
Also added for already-merged SourcesLogic
* Move button loading action to finally block
* Move route strings to inline
0 commit comments