Skip to content

Commit e6dfbee

Browse files
[Search] Fix autogenerated connector names (#197585)
Improve the autogenerated connector names by - Re-generating names when changing connector source - Preventing editing of names after connector is created (cherry picked from commit c05e1c5)
1 parent ede41c1 commit e6dfbee

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/connectors/create_connector/start_step.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ export const StartStep: React.FC<StartStepProps> = ({
106106
name="first"
107107
value={rawName}
108108
onChange={handleNameChange}
109+
disabled={!!connector}
109110
onBlur={() => {
110111
if (selectedConnector) {
111112
generateConnectorName({

x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/new_index/method_connector/new_connector_logic.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,7 @@ export const NewConnectorLogic = kea<MakeLogicType<NewConnectorValues, NewConnec
143143
}
144144
},
145145
connectorNameGenerated: ({ connectorName }) => {
146-
if (!values.rawName) {
147-
actions.setRawName(connectorName);
148-
}
146+
actions.setRawName(connectorName);
149147
},
150148
createConnector: ({
151149
isSelfManaged,
@@ -191,7 +189,6 @@ export const NewConnectorLogic = kea<MakeLogicType<NewConnectorValues, NewConnec
191189
setSelectedConnector: ({ connector }) => {
192190
if (connector) {
193191
actions.generateConnectorName({
194-
connectorName: values.rawName,
195192
connectorType: connector.serviceType,
196193
});
197194
}

0 commit comments

Comments
 (0)