Skip to content

Commit e36d273

Browse files
committed
[ML] Update jest tests with helper, rename helper for clarity
1 parent 6ccf6e1 commit e36d273

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

x-pack/plugins/index_lifecycle_management/__jest__/__snapshots__/policy_table.test.tsx.snap

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,15 @@ const testPolicy = {
5252
},
5353
};
5454

55-
const isLinkedWithIndices = (i: number) => i > 0 && i % 2 === 0;
55+
const isUsedByAnIndex = (i: number) => i % 2 === 0;
5656
const isDesignatedManagedPolicy = (i: number) => i > 0 && i % 3 === 0;
57+
5758
const policies: PolicyFromES[] = [testPolicy];
5859
for (let i = 1; i < 105; i++) {
5960
policies.push({
6061
version: i,
6162
modifiedDate: moment().subtract(i, 'days').toISOString(),
62-
indices: i % 2 === 0 ? [`index${i}`] : [],
63+
indices: isUsedByAnIndex(i) ? [`index${i}`] : [],
6364
indexTemplates: i % 2 === 0 ? [`indexTemplate${i}`] : [],
6465
name: `testy${i}`,
6566
policy: {
@@ -106,7 +107,7 @@ const getPolicies = (rendered: ReactWrapper) => {
106107
version,
107108
name,
108109
isManagedPolicy: isDesignatedManagedPolicy(version),
109-
isLinkedWithIndices: isLinkedWithIndices(version),
110+
isUsedByAnIndex: isUsedByAnIndex(version),
110111
};
111112
});
112113
return visiblePolicies;
@@ -235,7 +236,11 @@ describe('policy table', () => {
235236
});
236237
test('delete policy button is enabled when there are no linked indices', () => {
237238
const rendered = mountWithIntl(component);
238-
const policyRow = findTestSubject(rendered, `policyTableRow-testy1`);
239+
const visiblePolicies = getPolicies(rendered);
240+
const usedPolicy = visiblePolicies.find((p) => !p.isUsedByAnIndex);
241+
expect(usedPolicy).toBeDefined();
242+
243+
const policyRow = findTestSubject(rendered, `policyTableRow-${usedPolicy!.name}`);
239244
const deleteButton = findTestSubject(policyRow, 'deletePolicy');
240245
expect(deleteButton.props().disabled).toBeFalsy();
241246
});
@@ -266,7 +271,7 @@ describe('policy table', () => {
266271
rendered.update();
267272

268273
const visiblePolicies = getPolicies(rendered);
269-
const managedPolicy = visiblePolicies.find((p) => p.isManagedPolicy && !p.isLinkedWithIndices);
274+
const managedPolicy = visiblePolicies.find((p) => p.isManagedPolicy && !p.isUsedByAnIndex);
270275
expect(managedPolicy).toBeDefined();
271276

272277
const policyRow = findTestSubject(rendered, `policyTableRow-${managedPolicy!.name}`);

0 commit comments

Comments
 (0)