[Code] apply repo search scope right away in search page (#34029)

Author: mw-ding

x-pack/plugins/code/public/components/main/search_bar.tsx

@@ -100,6 +100,7 @@ export class CodeSearchBar extends React.Component<Props> {
           appName="code"
           disableAutoFocus={true}
           suggestionProviders={this.suggestionProviders}
+          enableSubmitWhenOptionsChanged={false}
           onSearchScopeChanged={this.props.onSearchScopeChanged}
           ref={instance => {
             if (instance) {

x-pack/plugins/code/public/components/query_bar/components/__snapshots__/query_bar.test.tsx.snap

@@ -4,6 +4,7 @@ exports[`render correctly with empty query string 1`] = `
 <CodeQueryBar
   appName="mockapp"
   disableAutoFocus={false}
+  enableSubmitWhenOptionsChanged={false}
   onSearchScopeChanged={[Function]}
   onSelect={[Function]}
   onSubmit={[Function]}
@@ -727,6 +728,7 @@ exports[`render correctly with input query string changed 1`] = `
     <CodeQueryBar
       appName="mockapp"
       disableAutoFocus={false}
+      enableSubmitWhenOptionsChanged={false}
       onSearchScopeChanged={[Function]}
       onSelect={[Function]}
       onSubmit={[Function]}

x-pack/plugins/code/public/components/query_bar/components/query_bar.test.tsx

@@ -35,6 +35,7 @@ test('render correctly with empty query string', () => {
       disableAutoFocus={false}
       appName="mockapp"
       suggestionProviders={[]}
+      enableSubmitWhenOptionsChanged={false}
       onSubmit={emptyFn}
       onSelect={emptyFn}
       onSearchScopeChanged={emptyFn}
@@ -94,6 +95,7 @@ test('render correctly with input query string changed', done => {
           mockSymbolSuggestionsProvider,
           mockRepositorySuggestionsProvider,
         ]}
+        enableSubmitWhenOptionsChanged={false}
         onSubmit={submitSpy}
         onSelect={emptyFn}
         onSearchScopeChanged={emptyFn}

x-pack/plugins/code/public/components/query_bar/components/query_bar.tsx

@@ -46,6 +46,7 @@ interface Props {
   suggestionProviders: SuggestionsProvider[];
   repositorySearch: (p: { query: string }) => void;
   saveSearchOptions: (searchOptions: ISearchOptions) => void;
+  enableSubmitWhenOptionsChanged: boolean;
   onSearchScopeChanged: (s: SearchScope) => void;
   repoSearchResults: any[];
   searchLoading: boolean;
@@ -373,6 +374,15 @@ export class CodeQueryBar extends Component<Props, State> {
     if (prevProps.query !== this.props.query) {
       this.updateSuggestions();
     }
+
+    // When search options (e.g. repository scopes) change,
+    // submit the search query again to refresh the search result.
+    if (
+      this.props.enableSubmitWhenOptionsChanged &&
+      !_.isEqual(prevProps.searchOptions, this.props.searchOptions)
+    ) {
+      this.onSubmit();
+    }
   }
 
   public componentWillUnmount() {

x-pack/plugins/code/public/components/search_page/search_bar.tsx

@@ -105,6 +105,7 @@ export class SearchBar extends React.PureComponent<Props> {
           appName="code"
           suggestionProviders={suggestionProviders}
           onSearchScopeChanged={this.props.onSearchScopeChanged}
+          enableSubmitWhenOptionsChanged={true}
           ref={instance => {
             if (instance) {
               // @ts-ignore