Skip to content

Commit d704232

Browse files
committed
Match the no results found
1 parent 75486b7 commit d704232

File tree

3 files changed

+36
-9
lines changed

3 files changed

+36
-9
lines changed

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/embeddables/grid_embeddable/grid_embeddable.tsx

Lines changed: 31 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { CoreStart } from 'kibana/public';
1010
import ReactDOM from 'react-dom';
1111
import React, { Suspense, useCallback, useState } from 'react';
1212
import useObservable from 'react-use/lib/useObservable';
13-
import { EuiEmptyPrompt } from '@elastic/eui';
13+
import { EuiEmptyPrompt, EuiIcon, EuiSpacer, EuiText } from '@elastic/eui';
1414
import { Filter } from '@kbn/es-query';
1515
import { Required } from 'utility-types';
1616
import { FormattedMessage } from '@kbn/i18n/react';
@@ -79,10 +79,8 @@ export const EmbeddableWrapper = ({
7979
},
8080
[dataVisualizerListState, onOutputChange]
8181
);
82-
const { configs, searchQueryLanguage, searchString, extendedColumns } = useDataVisualizerGridData(
83-
input,
84-
dataVisualizerListState
85-
);
82+
const { configs, searchQueryLanguage, searchString, extendedColumns, loaded } =
83+
useDataVisualizerGridData(input, dataVisualizerListState);
8684
const getItemIdToExpandedRowMap = useCallback(
8785
function (itemIds: string[], items: FieldVisConfig[]): ItemIdToExpandedRowMap {
8886
return itemIds.reduce((m: ItemIdToExpandedRowMap, fieldName: string) => {
@@ -103,6 +101,34 @@ export const EmbeddableWrapper = ({
103101
[input, searchQueryLanguage, searchString]
104102
);
105103

104+
if (
105+
loaded &&
106+
(configs.length === 0 ||
107+
// FIXME: Configs might have a placeholder document count stats field
108+
// This will be removed in the future
109+
(configs.length === 1 && configs[0].fieldName === undefined))
110+
) {
111+
return (
112+
<div
113+
style={{
114+
display: 'flex',
115+
flexDirection: 'column',
116+
justifyContent: 'center',
117+
flex: '1 0 100%',
118+
textAlign: 'center',
119+
}}
120+
>
121+
<EuiText size="xs" color="subdued">
122+
<EuiIcon type="visualizeApp" size="m" color="subdued" />
123+
<EuiSpacer size="m" />
124+
<FormattedMessage
125+
id="xpack.dataVisualizer.index.embeddableNoResultsMessage"
126+
defaultMessage="No results found"
127+
/>
128+
</EuiText>
129+
</div>
130+
);
131+
}
106132
return (
107133
<DataVisualizerTable<FieldVisConfig>
108134
items={configs}

x-pack/plugins/data_visualizer/public/application/index_data_visualizer/embeddables/grid_embeddable/use_data_visualizer_grid_data.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,5 +582,6 @@ export const useDataVisualizerGridData = (
582582
extendedColumns,
583583
documentCountStats,
584584
metricsStats,
585+
loaded: metricsLoaded && nonMetricsLoaded,
585586
};
586587
};

x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_grid_in_discover.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,10 +154,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
154154

155155
runTests(farequoteIndexPatternTestData);
156156
runTests(farequoteKQLSearchTestData);
157-
// runTests(farequoteLuceneSearchTestData);
158-
// runTests(farequoteKQLFiltersSearchTestData);
159-
// runTests(farequoteLuceneFiltersSearchTestData);
160-
// runTests(sampleLogTestData);
157+
runTests(farequoteLuceneSearchTestData);
158+
runTests(farequoteKQLFiltersSearchTestData);
159+
runTests(farequoteLuceneFiltersSearchTestData);
160+
runTests(sampleLogTestData);
161161
});
162162

163163
describe('when disabled', function () {

0 commit comments

Comments
 (0)