Revert "[NP] Move IndexPatterns into the NP (#51199)"

This reverts commit 3a0d5f4.

Author: brianseeders

src/legacy/core_plugins/data/public/filter/action/apply_filter_action.ts

@@ -32,9 +32,8 @@ import {
   applyFiltersPopover,
   changeTimeFilter,
   extractTimeFilter,
-  IndexPatternsStart,
 } from '../../../../../../plugins/data/public';
-
+import { IndexPatternsStart } from '../../index_patterns';
 export const GLOBAL_APPLY_FILTER_ACTION = 'GLOBAL_APPLY_FILTER_ACTION';
 
 interface ActionContext {
@@ -75,7 +74,7 @@ export function createFilterAction(
       if (selectedFilters.length > 1) {
         const indexPatterns = await Promise.all(
           filters.map(filter => {
-            return indexPatternsService.indexPatterns.get(filter.meta.index!);
+            return indexPatternsService.indexPatterns.get(filter.meta.index);
           })
         );
 

src/legacy/core_plugins/data/public/index.ts

@@ -48,4 +48,4 @@ export {
 /** @public static code */
 export * from '../common';
 export { FilterStateManager } from './filter/filter_manager';
-export { getFromSavedObject, getRoutes, flattenHitWrapper } from './index_patterns';
+export { getFromSavedObject, getRoutes } from './index_patterns';

src/plugins/data/public/index_patterns/fields/field.ts renamed to src/legacy/core_plugins/data/public/index_patterns/fields/field.ts

@@ -20,19 +20,26 @@
 import { i18n } from '@kbn/i18n';
 // @ts-ignore
 import { ObjDefine } from './obj_define';
+// @ts-ignore
+import { shortenDottedString } from '../../../../../core_plugins/kibana/common/utils/shorten_dotted_string';
 import { IndexPattern } from '../index_patterns';
 import { getNotifications, getFieldFormats } from '../services';
+
 import {
-  IFieldType,
+  FieldFormat,
   getKbnFieldType,
+  IFieldType,
   IFieldSubType,
-  FieldFormat,
-  shortenDottedString,
-} from '../../../common';
+} from '../../../../../../plugins/data/public';
 
 export type FieldSpec = Record<string, any>;
 
-export class Field implements IFieldType {
+/** @deprecated
+ *  Please use IFieldType instead
+ * */
+export type FieldType = IFieldType;
+
+export class Field implements FieldType {
   name: string;
   type: string;
   script?: string;

src/plugins/data/public/index_patterns/fields/field_list.ts renamed to src/legacy/core_plugins/data/public/index_patterns/fields/field_list.ts

@@ -19,16 +19,15 @@
 
 import { findIndex } from 'lodash';
 import { IndexPattern } from '../index_patterns';
-import { IFieldType } from '../../../common';
-import { Field, FieldSpec } from './field';
+import { Field, FieldType, FieldSpec } from './field';
 
 type FieldMap = Map<Field['name'], Field>;
 
 export interface FieldListInterface extends Array<Field> {
   getByName(name: Field['name']): Field | undefined;
   getByType(type: Field['type']): Field[];
   add(field: FieldSpec): void;
-  remove(field: IFieldType): void;
+  remove(field: FieldType): void;
 }
 
 export class FieldList extends Array<Field> implements FieldListInterface {
@@ -43,7 +42,7 @@ export class FieldList extends Array<Field> implements FieldListInterface {
     }
     this.groups.get(field.type)!.set(field.name, field);
   };
-  private removeByGroup = (field: IFieldType) => this.groups.get(field.type)!.delete(field.name);
+  private removeByGroup = (field: FieldType) => this.groups.get(field.type)!.delete(field.name);
 
   constructor(indexPattern: IndexPattern, specs: FieldSpec[] = [], shortDotsEnable = false) {
     super();
@@ -62,7 +61,7 @@ export class FieldList extends Array<Field> implements FieldListInterface {
     this.setByGroup(newField);
   };
 
-  remove = (field: IFieldType) => {
+  remove = (field: FieldType) => {
     this.removeByGroup(field);
     this.byName.delete(field.name);
 

src/plugins/data/public/index_patterns/fields/index.ts renamed to src/legacy/core_plugins/data/public/index_patterns/fields/index.ts

@@ -17,21 +17,4 @@
  * under the License.
  */
 
-import { IFieldType, IIndexPattern, indexPatterns } from '../../../../../plugins/data/public';
-
-const getFromSavedObject = indexPatterns.getFromSavedObject;
-const getRoutes = indexPatterns.getRoutes;
-const flattenHitWrapper = indexPatterns.flattenHitWrapper;
-
-export { getFromSavedObject, getRoutes, flattenHitWrapper };
-export { IFieldType as FieldType };
-export { IIndexPattern as StaticIndexPattern };
-export {
-  Field,
-  FieldListInterface,
-  IndexPattern,
-  IndexPatterns,
-  IndexPatternsStart,
-  IndexPatternsSetup,
-  IndexPatternsService,
-} from '../../../../../plugins/data/public';
+export * from './index_patterns_service';

src/plugins/data/public/index_patterns/fields/obj_define.js renamed to src/legacy/core_plugins/data/public/index_patterns/fields/obj_define.js

@@ -19,7 +19,7 @@
 
 import { IndexPattern } from './index_pattern';
 
-interface PatternCache {
+export interface PatternCache {
   get: (id: string) => IndexPattern;
   set: (id: string, value: IndexPattern) => IndexPattern;
   clear: (id: string) => void;