Fixed NaN comparison (#50000) (#51970)

Tim Roes · web-flow · commit cb91d606dff0 · 2019-12-02T17:00:50.000+01:00
diff --git a/src/legacy/core_plugins/vis_type_timeseries/public/components/color_rules.js b/src/legacy/core_plugins/vis_type_timeseries/public/components/color_rules.js
@@ -46,7 +46,7 @@ class ColorRulesUI extends Component {
       const part = {};
       part[name] = cast(_.get(e, '[0].value', _.get(e, 'target.value')));
       if (part[name] === 'undefined') part[name] = undefined;
-      if (part[name] === NaN) part[name] = undefined;
+      if (isNaN(part[name])) part[name] = undefined;
       handleChange(_.assign({}, item, part));
     };
   }

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class ColorRulesUI extends Component {`
`46`	`46`	`const part = {};`
`47`	`47`	`part[name] = cast(_.get(e, '[0].value', _.get(e, 'target.value')));`
`48`	`48`	`if (part[name] === 'undefined') part[name] = undefined;`
`49`		`- if (part[name] === NaN) part[name] = undefined;`
	`49`	`+ if (isNaN(part[name])) part[name] = undefined;`
`50`	`50`	`handleChange(_.assign({}, item, part));`
`51`	`51`	`};`
`52`	`52`	`}`