Skip to content

Commit c7f9e12

Browse files
committed
Address nits
1 parent 129d6b4 commit c7f9e12

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

src/core/server/http/cookie_session_storage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export async function createCookieSessionStorageFactory<T>(
114114
basePath?: string
115115
): Promise<SessionStorageFactory<T>> {
116116
function clearInvalidCookie(req: Request | undefined, path: string = basePath || '/') {
117-
// if the cookie did not include the 'path' or 'isSecure' attributes in the session value, it is a legacy cookie
117+
// if the cookie did not include the 'path' attribute in the session value, it is a legacy cookie
118118
// we will assume that the cookie was created with the current configuration
119119
log.debug(`Clearing invalid session cookie`);
120120
// need to use Hapi toolkit to clear cookie with defined options

x-pack/plugins/security/server/authentication/authenticator.test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,7 @@ function getMockOptions(config: Partial<AuthenticatorOptions['config']> = {}) {
2828
basePath: httpServiceMock.createSetupContract().basePath,
2929
loggers: loggingServiceMock.create(),
3030
isSystemAPIRequest: jest.fn(),
31-
config: {
32-
sessionTimeout: null,
33-
authc: { providers: [], oidc: {}, saml: {} },
34-
secureCookies: false,
35-
...config,
36-
},
31+
config: { sessionTimeout: null, authc: { providers: [], oidc: {}, saml: {} }, ...config },
3732
sessionStorageFactory: sessionStorageMock.createFactory<ProviderSession>(),
3833
};
3934
}

0 commit comments

Comments
 (0)