Fix test failures

Author: nickpeihl

packages/core/saved-objects/core-saved-objects-migration-server-internal/src/kibana_migrator_utils.fixtures.ts

@@ -1504,6 +1504,23 @@ export const INDEX_MAP_BEFORE_SPLIT: IndexMap = {
           },
         },
       },
+      navigation_embeddable: {
+        properties: {
+          id: {
+            type: 'text',
+          },
+          title: {
+            type: 'text',
+          },
+          description: {
+            type: 'text',
+          },
+          links: {
+            dynamic: false,
+            properties: {},
+          },
+        },
+      },
       'cases-comments': {
         dynamic: false,
         properties: {

src/core/server/integration_tests/saved_objects/migrations/group2/check_registered_types.test.ts

@@ -120,6 +120,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
         "ml-module": "2225cbb4bd508ea5f69db4b848be9d8a74b60198",
         "ml-trained-model": "482195cefd6b04920e539d34d7356d22cb68e4f3",
         "monitoring-telemetry": "5d91bf75787d9d4dd2fae954d0b3f76d33d2e559",
+        "navigation_embeddable": "de71a127ed325261ca6bc926d93c4cd676d17a05",
         "observability-onboarding-state": "55b112d6a33fedb7c1e4fec4da768d2bcc5fadc2",
         "osquery-manager-usage-metric": "983bcbc3b7dda0aad29b20907db233abba709bcc",
         "osquery-pack": "6ab4358ca4304a12dcfc1777c8135b75cffb4397",

src/core/server/integration_tests/saved_objects/migrations/group5/dot_kibana_split.test.ts

@@ -240,6 +240,7 @@ describe('split .kibana index into multiple system indices', () => {
             "ml-module",
             "ml-trained-model",
             "monitoring-telemetry",
+            "navigation_embeddable",
             "observability-onboarding-state",
             "osquery-manager-usage-metric",
             "osquery-pack",

src/plugins/navigation_embeddable/public/components/navigation_embeddable_link_editor.tsx

@@ -34,8 +34,8 @@ import {
   EXTERNAL_LINK_TYPE,
   DASHBOARD_LINK_TYPE,
   NavigationEmbeddableLink,
-  DashboardItem,
 } from '../../common/content_management';
+import { DashboardItem } from '../embeddable/types';
 import { NavEmbeddableStrings } from './navigation_embeddable_strings';
 import { NavigationEmbeddableUnorderedLink } from '../editor/open_link_editor_flyout';
 import { ExternalLinkDestinationPicker } from './external_link/external_link_destination_picker';

src/plugins/navigation_embeddable/public/components/navigation_embeddable_strings.ts

@@ -69,7 +69,7 @@ export const NavEmbeddableStrings = {
           defaultMessage: 'Update library item',
         }),
       getUpdateLibraryItemButtonTooltip: () =>
-        i18n.translate('navigationEmbeddable.panelEditor.updateLibraryItemButtonLabel', {
+        i18n.translate('navigationEmbeddable.panelEditor.updateLibraryItemButtonTooltip', {
           defaultMessage: 'Editing this panel might affect other dashboards.',
         }),
       getTitleInputLabel: () =>