Merge branch 'main' into feat/action-batch-async

Author: kibanamachine

.github/CODEOWNERS

@@ -13,6 +13,7 @@
 /src/plugins/saved_search/ @elastic/kibana-data-discovery
 /x-pack/plugins/discover_enhanced/ @elastic/kibana-data-discovery
 /test/functional/apps/discover/ @elastic/kibana-data-discovery
+/test/functional/apps/context/ @elastic/kibana-data-discovery
 /test/api_integration/apis/unified_field_list/ @elastic/kibana-data-discovery
 /x-pack/plugins/graph/ @elastic/kibana-data-discovery
 /x-pack/test/functional/apps/graph @elastic/kibana-data-discovery

packages/kbn-user-profile-components/src/user_profiles_popover.test.tsx

@@ -8,10 +8,11 @@
 
 import { shallow } from 'enzyme';
 import React from 'react';
+import { UserProfile } from './user_profile';
 
 import { UserProfilesPopover } from './user_profiles_popover';
 
-const userProfiles = [
+const userProfiles: UserProfile[] = [
   {
     uid: 'u_BOulL4QMPSyV9jg5lQI2JmCkUnokHTazBnet3xVHNv0_0',
     enabled: true,

packages/kbn-user-profile-components/src/user_profiles_selectable.test.tsx

@@ -8,10 +8,11 @@
 
 import { mount } from 'enzyme';
 import React from 'react';
+import { UserProfile } from './user_profile';
 
 import { UserProfilesSelectable } from './user_profiles_selectable';
 
-const userProfiles = [
+const userProfiles: UserProfile[] = [
   {
     uid: 'u_BOulL4QMPSyV9jg5lQI2JmCkUnokHTazBnet3xVHNv0_0',
     enabled: true,

src/plugins/discover/public/embeddable/saved_search_embeddable.tsx

@@ -484,6 +484,8 @@ export class SavedSearchEmbeddable
       ReactDOM.unmountComponentAtNode(this.node);
     }
     this.node = domNode;
+
+    this.renderReactComponent(this.node, this.searchProps!);
   }
 
   private renderReactComponent(domNode: HTMLElement, searchProps: SearchProps) {

src/plugins/discover/public/services/doc_views/components/doc_viewer_table/table_cell_actions.tsx

@@ -177,15 +177,13 @@ export const TableActions = ({
     },
   ];
 
-  const testSubject = `openFieldActionsButton-${field}`;
-
   if (mode === 'inline') {
     return (
       <EuiFlexGroup
         responsive={false}
         gutterSize="xs"
         className="kbnDocViewer__buttons"
-        data-test-subj={testSubject}
+        data-test-subj={`fieldActionsGroup-${field}`}
       >
         {panels[0].items.map((item) => (
           <EuiFlexItem key={item.icon} grow={false}>
@@ -210,7 +208,7 @@ export const TableActions = ({
     <EuiPopover
       button={
         <EuiButtonIcon
-          data-test-subj={testSubject}
+          data-test-subj={`openFieldActionsButton-${field}`}
           aria-label={openActionsLabel}
           onClick={toggleOpenPopover}
           iconType="boxesHorizontal"

test/accessibility/apps/discover.ts

@@ -117,13 +117,21 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     it('a11y test for actions on a field', async () => {
       await PageObjects.discover.clickDocViewerTab(0);
-      await testSubjects.click('openFieldActionsButton-Cancelled');
+      if (await testSubjects.exists('openFieldActionsButton-Cancelled')) {
+        await testSubjects.click('openFieldActionsButton-Cancelled');
+      } else {
+        await testSubjects.existOrFail('fieldActionsGroup-Cancelled');
+      }
       await a11y.testAppSnapshot();
     });
 
     it('a11y test for data-grid table with columns', async () => {
       await testSubjects.click('toggleColumnButton-Cancelled');
-      await testSubjects.click('openFieldActionsButton-Carrier');
+      if (await testSubjects.exists('openFieldActionsButton-Carrier')) {
+        await testSubjects.click('openFieldActionsButton-Carrier');
+      } else {
+        await testSubjects.existOrFail('fieldActionsGroup-Carrier');
+      }
       await testSubjects.click('toggleColumnButton-Carrier');
       await testSubjects.click('euiFlyoutCloseButton');
       await toasts.dismissAllToasts();

test/functional/apps/context/_filters.ts

@@ -18,7 +18,6 @@ const TEST_COLUMN_NAMES = ['extension', 'geo.src'];
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const dataGrid = getService('dataGrid');
   const filterBar = getService('filterBar');
-  const testSubjects = getService('testSubjects');
   const retry = getService('retry');
   const browser = getService('browser');
 
@@ -34,12 +33,17 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     it('inclusive filter should be addable via expanded data grid rows', async function () {
       await retry.waitFor(`filter ${TEST_ANCHOR_FILTER_FIELD} in filterbar`, async () => {
         await dataGrid.clickRowToggle({ isAnchorRow: true, renderMoreRows: true });
-        await testSubjects.click(`openFieldActionsButton-${TEST_ANCHOR_FILTER_FIELD}`);
-        await testSubjects.click(`addFilterForValueButton-${TEST_ANCHOR_FILTER_FIELD}`);
+        await dataGrid.clickFieldActionInFlyout(
+          TEST_ANCHOR_FILTER_FIELD,
+          'addFilterForValueButton'
+        );
         await PageObjects.context.waitUntilContextLoadingHasFinished();
 
         return await filterBar.hasFilter(TEST_ANCHOR_FILTER_FIELD, TEST_ANCHOR_FILTER_VALUE, true);
       });
+
+      await dataGrid.closeFlyout();
+
       await retry.waitFor(`filter matching docs in data grid`, async () => {
         const fields = await dataGrid.getFields();
         return fields
@@ -71,8 +75,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     it('filter for presence should be addable via expanded data grid rows', async function () {
       await retry.waitFor('an exists filter in the filterbar', async () => {
         await dataGrid.clickRowToggle({ isAnchorRow: true, renderMoreRows: true });
-        await testSubjects.click(`openFieldActionsButton-${TEST_ANCHOR_FILTER_FIELD}`);
-        await testSubjects.click(`addExistsFilterButton-${TEST_ANCHOR_FILTER_FIELD}`);
+        await dataGrid.clickFieldActionInFlyout(TEST_ANCHOR_FILTER_FIELD, 'addExistsFilterButton');
         await PageObjects.context.waitUntilContextLoadingHasFinished();
         return await filterBar.hasFilter(TEST_ANCHOR_FILTER_FIELD, 'exists', true);
       });

test/functional/apps/discover/embeddable/_saved_search_embeddable.ts

@@ -77,5 +77,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
       await dataGrid.checkCurrentRowsPerPageToBe(10);
     });
+
+    it('should render duplicate saved search embeddables', async () => {
+      await PageObjects.dashboard.switchToEditMode();
+      await addSearchEmbeddableToDashboard();
+      const [firstGridCell, secondGridCell] = await dataGrid.getAllCellElements();
+      const firstGridCellContent = await firstGridCell.getVisibleText();
+      const secondGridCellContent = await secondGridCell.getVisibleText();
+
+      expect(firstGridCellContent).to.be.equal(secondGridCellContent);
+    });
   });
 }

test/functional/apps/discover/group2/_data_grid_doc_navigation.ts

@@ -60,9 +60,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.discover.waitUntilSearchingHasFinished();
 
       await dataGrid.clickRowToggle({ rowIndex: 0 });
-
-      await testSubjects.click('openFieldActionsButton-@timestamp');
-      await testSubjects.click('addExistsFilterButton-@timestamp');
+      await dataGrid.clickFieldActionInFlyout('@timestamp', 'addExistsFilterButton');
 
       const hasExistsFilter = await filterBar.hasFilter('@timestamp', 'exists', true, false, false);
       expect(hasExistsFilter).to.be(true);

test/functional/apps/discover/group2/_data_grid_doc_table.ts

@@ -197,17 +197,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           // add columns
           const fields = ['_id', '_index', 'agent'];
           for (const field of fields) {
-            await testSubjects.click(`openFieldActionsButton-${field}`);
-            await testSubjects.click(`toggleColumnButton-${field}`);
+            await dataGrid.clickFieldActionInFlyout(field, 'toggleColumnButton');
           }
 
           const headerWithFields = await dataGrid.getHeaderFields();
           expect(headerWithFields.join(' ')).to.contain(fields.join(' '));
 
           // remove columns
           for (const field of fields) {
-            await testSubjects.click(`openFieldActionsButton-${field}`);
-            await testSubjects.click(`toggleColumnButton-${field}`);
+            await dataGrid.clickFieldActionInFlyout(field, 'toggleColumnButton');
           }
 
           const headerWithoutFields = await dataGrid.getHeaderFields();