Improve visualization typings (#79128)

* Improve visualization typings

* Fix vis selection dialog

* Fix broken getInfoMessage type

Co-authored-by: Kibana Machine <[email protected]>

Author: Tim Roes

src/plugins/tile_map/public/components/tile_map_options.tsx

@@ -76,7 +76,7 @@ function TileMapOptions(props: TileMapOptionsProps) {
         <BasicOptions {...props} />
 
         <SwitchOption
-          disabled={!vis.type.visConfig.canDesaturate}
+          disabled={!vis.type.visConfig?.canDesaturate}
           label={i18n.translate('tileMap.visParams.desaturateTilesLabel', {
             defaultMessage: 'Desaturate tiles',
           })}

src/plugins/tile_map/public/tile_map_type.js

@@ -55,7 +55,6 @@ export function createTileMapTypeDefinition(dependencies) {
         wms: uiSettings.get('visualization:tileMap:WMSdefaults'),
       },
     },
-    requiresPartialRows: true,
     visualization: CoordinateMapsVisualization,
     responseHandler: convertToGeoJson,
     editorConfig: {

src/plugins/vis_default_editor/public/components/sidebar/sidebar.tsx

@@ -18,7 +18,7 @@
  */
 
 import React, { useMemo, useState, useCallback, KeyboardEventHandler, useEffect } from 'react';
-import { get, isEqual } from 'lodash';
+import { isEqual } from 'lodash';
 import { i18n } from '@kbn/i18n';
 import { keys, EuiButtonIcon, EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
 import { EventEmitter } from 'events';
@@ -71,7 +71,7 @@ function DefaultEditorSideBar({
   ]);
   const metricSchemas = (vis.type.schemas.metrics || []).map((s: Schema) => s.name);
   const metricAggs = useMemo(
-    () => responseAggs.filter((agg) => metricSchemas.includes(get(agg, 'schema'))),
+    () => responseAggs.filter((agg) => agg.schema && metricSchemas.includes(agg.schema)),
     [responseAggs, metricSchemas]
   );
   const hasHistogramAgg = useMemo(() => responseAggs.some((agg) => agg.type.name === 'histogram'), [

src/plugins/vis_type_metric/public/to_ast.ts

@@ -39,7 +39,7 @@ export const toExpressionAst = (vis: Vis, params: any) => {
   const esaggs = buildExpressionFunction<EsaggsExpressionFunctionDefinition>('esaggs', {
     index: vis.data.indexPattern!.id!,
     metricsAtAllLevels: vis.isHierarchical(),
-    partialRows: vis.type.requiresPartialRows || vis.params.showPartialRows || false,
+    partialRows: vis.params.showPartialRows || false,
     aggConfigs: JSON.stringify(vis.data.aggs!.aggs),
     includeFormatHints: false,
   });

src/plugins/vis_type_table/public/table_vis_controller.test.ts

@@ -249,13 +249,13 @@ describe('Table Vis - Controller', () => {
     const vis = getRangeVis({ showPartialRows: true });
     initController(vis);
 
-    expect(vis.type.hierarchicalData(vis)).toEqual(true);
+    expect((vis.type.hierarchicalData as Function)(vis)).toEqual(true);
   });
 
   test('passes partialRows:false to tabify based on the vis params', () => {
     const vis = getRangeVis({ showPartialRows: false });
     initController(vis);
 
-    expect(vis.type.hierarchicalData(vis)).toEqual(false);
+    expect((vis.type.hierarchicalData as Function)(vis)).toEqual(false);
   });
 });

src/plugins/vis_type_table/public/table_vis_type.ts

@@ -20,7 +20,7 @@ import { CoreSetup, PluginInitializerContext } from 'kibana/public';
 import { i18n } from '@kbn/i18n';
 import { AggGroupNames } from '../../data/public';
 import { Schemas } from '../../vis_default_editor/public';
-import { BaseVisTypeOptions, Vis } from '../../visualizations/public';
+import { BaseVisTypeOptions } from '../../visualizations/public';
 import { tableVisResponseHandler } from './table_vis_response_handler';
 // @ts-ignore
 import tableVisTemplate from './table_vis.html';
@@ -99,7 +99,7 @@ export function getTableVisTypeDefinition(
       ]),
     },
     responseHandler: tableVisResponseHandler,
-    hierarchicalData: (vis: Vis) => {
+    hierarchicalData: (vis) => {
       return Boolean(vis.params.showPartialRows || vis.params.showMetricsAtAllLevels);
     },
   };

src/plugins/vis_type_table/public/vis_controller.ts

@@ -103,7 +103,9 @@ export function getTableVisualizationControllerClass(
           this.$scope = this.$rootScope.$new();
           this.$scope.uiState = this.vis.getUiState();
           updateScope();
-          this.el.find('div').append(this.$compile(this.vis.type!.visConfig.template)(this.$scope));
+          this.el
+            .find('div')
+            .append(this.$compile(this.vis.type.visConfig?.template ?? '')(this.$scope));
           this.$scope.$apply();
         } else {
           updateScope();

src/plugins/vis_type_tagcloud/public/to_ast.ts

@@ -38,7 +38,7 @@ export const toExpressionAst = (vis: Vis<TagCloudVisParams>, params: BuildPipeli
   const esaggs = buildExpressionFunction<EsaggsExpressionFunctionDefinition>('esaggs', {
     index: vis.data.indexPattern!.id!,
     metricsAtAllLevels: vis.isHierarchical(),
-    partialRows: vis.type.requiresPartialRows || false,
+    partialRows: false,
     aggConfigs: JSON.stringify(vis.data.aggs!.aggs),
     includeFormatHints: false,
   });

src/plugins/vis_type_vega/public/vega_type.ts

@@ -18,6 +18,7 @@
  */
 
 import { i18n } from '@kbn/i18n';
+import { BaseVisTypeOptions } from 'src/plugins/visualizations/public';
 import { DefaultEditorSize } from '../../vis_default_editor/public';
 import { VegaVisualizationDependencies } from './plugin';
 import { VegaVisEditor } from './components';
@@ -31,7 +32,9 @@ import { VIS_EVENT_TO_TRIGGER } from '../../visualizations/public';
 
 import { getInfoMessage } from './components/experimental_map_vis_info';
 
-export const createVegaTypeDefinition = (dependencies: VegaVisualizationDependencies) => {
+export const createVegaTypeDefinition = (
+  dependencies: VegaVisualizationDependencies
+): BaseVisTypeOptions => {
   const requestHandler = createVegaRequestHandler(dependencies);
   const visualization = createVegaVisualization(dependencies);
 

src/plugins/visualizations/public/components/visualization_chart.tsx

@@ -90,6 +90,12 @@ class VisualizationChart extends React.Component<VisualizationChartProps> {
     const { vis } = this.props;
     const Visualization = vis.type.visualization;
 
+    if (!Visualization) {
+      throw new Error(
+        'Tried to use VisualizationChart component with a vis without visualization property.'
+      );
+    }
+
     this.visualization = new Visualization(this.chartDiv.current, vis);
 
     // We know that containerDiv.current will never be null, since we will always