Skip to content

Commit a05fef2

Browse files
authored
Disable/enable filter with click+shift on a filter badge (#52751)
1 parent e488d9b commit a05fef2

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/plugins/data/public/ui/filter_bar/filter_item.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import { EuiContextMenu, EuiPopover } from '@elastic/eui';
2121
import { InjectedIntl, injectI18n } from '@kbn/i18n/react';
2222
import classNames from 'classnames';
23-
import React, { Component } from 'react';
23+
import React, { Component, MouseEvent } from 'react';
2424
import { IUiSettingsClient } from 'src/core/public';
2525
import { FilterEditor } from './filter_editor';
2626
import { FilterView } from './filter_view';
@@ -46,6 +46,13 @@ class FilterItemUI extends Component<Props, State> {
4646
isPopoverOpen: false,
4747
};
4848

49+
private handleBadgeClick = (e: MouseEvent<HTMLInputElement>) => {
50+
if (e.shiftKey) {
51+
this.onToggleDisabled();
52+
} else {
53+
this.togglePopover();
54+
}
55+
};
4956
public render() {
5057
const { filter, id } = this.props;
5158
const { negate, disabled } = filter.meta;
@@ -73,7 +80,7 @@ class FilterItemUI extends Component<Props, State> {
7380
valueLabel={valueLabel}
7481
className={classes}
7582
iconOnClick={() => this.props.onRemove()}
76-
onClick={this.togglePopover}
83+
onClick={this.handleBadgeClick}
7784
data-test-subj={`filter ${dataTestSubjDisabled} ${dataTestSubjKey} ${dataTestSubjValue}`}
7885
/>
7986
);

0 commit comments

Comments
 (0)