[Ingest Manager] Use docker registry for fleet api integration tests (#72621)

Author: nchaulet

x-pack/plugins/ingest_manager/README.md

@@ -45,63 +45,26 @@ One common development workflow is:
 This plugin follows the `common`, `server`, `public` structure from the [Architecture Style Guide
 ](https://github.com/elastic/kibana/blob/master/style_guides/architecture_style_guide.md#file-and-folder-structure). We also follow the pattern of developing feature branches under your personal fork of Kibana.
 
-### API Tests
+### Tests
 
-#### Ingest & Fleet
+#### API integration tests
 
-1. In one terminal, change to the `x-pack` directory and start the test server with
+You need to have `docker` to run ingest manager api integration tests
 
-   ```
-   node scripts/functional_tests_server.js --config test/api_integration/config.ts
-   ```
+1. In one terminal, run the tests from the Kibana root directory with
 
-1. in a second terminal, run the tests from the Kibana root directory with
    ```
-   node scripts/functional_test_runner.js --config x-pack/test/api_integration/config.ts
+   INGEST_MANAGEMENT_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:server --config x-pack/test/ingest_manager_api_integration/config.ts
    ```
 
-#### EPM
-
-1. In one terminal, change to the `x-pack` directory and start the test server with
+1. in a second terminal, run the tests from the Kibana root directory with
 
    ```
-   node scripts/functional_tests_server.js --config test/epm_api_integration/config.ts
+   INGEST_MANAGEMENT_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/ingest_manager_api_integration/config.ts
    ```
 
-1. in a second terminal, run the tests from the Kibana root directory with
+   Optionally you can filter which tests you want to run using `--grep`
+
    ```
-   node scripts/functional_test_runner.js --config x-pack/test/epm_api_integration/config.ts
+   INGEST_MANAGEMENT_PACKAGE_REGISTRY_PORT=12345 yarn test:ftr:runner --config x-pack/test/ingest_manager_api_integration/config.ts --grep='fleet'
    ```
-
-### Staying up-to-date with `master`
-
-While we're developing in the `feature-ingest` feature branch, here's is more information on keeping up to date with upstream kibana.
-
-<details>
-  <summary>merge upstream <code>master</code> into <code>feature-ingest</code></summary>
-
-```bash
-## checkout feature branch to your fork
-git checkout -B feature-ingest origin/feature-ingest
-
-## make sure your feature branch is current with upstream feature branch
-git pull upstream feature-ingest
-
-## pull in changes from upstream master
-git pull upstream master
-
-## push changes to your remote
-git push origin
-
-# /!\ Open a DRAFT PR /!\
-# Normal PRs will re-notify authors of commits already merged
-# Draft PR will trigger CI run. Once CI is green ...
-# /!\ DO NOT USE THE GITHUB UI TO MERGE THE PR /!\
-
-## push your changes to upstream feature branch from the terminal; not GitHub UI
-git push upstream
-```
-
-</details>
-
-See https://github.com/elastic/kibana/pull/37950 for an example.

x-pack/test/api_integration/apis/endpoint/artifacts/index.ts

@@ -9,7 +9,10 @@ import { createHash } from 'crypto';
 import { inflateSync } from 'zlib';
 
 import { FtrProviderContext } from '../../../ftr_provider_context';
-import { getSupertestWithoutAuth, setupIngest } from '../../fleet/agents/services';
+import {
+  getSupertestWithoutAuth,
+  setupIngest,
+} from '../../../../ingest_manager_api_integration/apis/fleet/agents/services';
 
 export default function (providerContext: FtrProviderContext) {
   const { getService } = providerContext;

x-pack/test/api_integration/apis/index.js

@@ -26,11 +26,9 @@ export default function ({ loadTestFile }) {
     loadTestFile(require.resolve('./security_solution'));
     loadTestFile(require.resolve('./short_urls'));
     loadTestFile(require.resolve('./lens'));
-    loadTestFile(require.resolve('./fleet'));
     loadTestFile(require.resolve('./ml'));
     loadTestFile(require.resolve('./transform'));
     loadTestFile(require.resolve('./endpoint'));
-    loadTestFile(require.resolve('./ingest_manager'));
     loadTestFile(require.resolve('./lists'));
     loadTestFile(require.resolve('./upgrade_assistant'));
   });

x-pack/test/api_integration/apis/ingest_manager/agent_config.ts renamed to x-pack/test/ingest_manager_api_integration/apis/agent_config/agent_config.ts

@@ -5,7 +5,7 @@
  */
 
 import expect from '@kbn/expect';
-import { FtrProviderContext } from '../../ftr_provider_context';
+import { FtrProviderContext } from '../../../api_integration/ftr_provider_context';
 
 export default function ({ getService }: FtrProviderContext) {
   const supertest = getService('supertest');

x-pack/test/api_integration/apis/ingest_manager/index.js renamed to x-pack/test/ingest_manager_api_integration/apis/agent_config/index.js

@@ -6,8 +6,7 @@
 
 import expect from '@kbn/expect';
 import uuid from 'uuid';
-
-import { FtrProviderContext } from '../../../ftr_provider_context';
+import { FtrProviderContext } from '../../../../api_integration/ftr_provider_context';
 import { getSupertestWithoutAuth } from './services';
 
 export default function (providerContext: FtrProviderContext) {

x-pack/test/api_integration/apis/fleet/agents/acks.ts renamed to x-pack/test/ingest_manager_api_integration/apis/fleet/agents/acks.ts

@@ -5,8 +5,7 @@
  */
 
 import expect from '@kbn/expect';
-
-import { FtrProviderContext } from '../../../ftr_provider_context';
+import { FtrProviderContext } from '../../../../api_integration/ftr_provider_context';
 
 export default function (providerContext: FtrProviderContext) {
   const { getService } = providerContext;

x-pack/test/api_integration/apis/fleet/agents/actions.ts renamed to x-pack/test/ingest_manager_api_integration/apis/fleet/agents/actions.ts

@@ -7,8 +7,9 @@
 import expect from '@kbn/expect';
 import uuid from 'uuid';
 
-import { FtrProviderContext } from '../../../ftr_provider_context';
+import { FtrProviderContext } from '../../../../api_integration/ftr_provider_context';
 import { getSupertestWithoutAuth, setupIngest } from './services';
+import { skipIfNoDockerRegistry } from '../../../helpers';
 
 export default function (providerContext: FtrProviderContext) {
   const { getService } = providerContext;
@@ -19,6 +20,7 @@ export default function (providerContext: FtrProviderContext) {
   let apiKey: { id: string; api_key: string };
 
   describe('fleet_agents_checkin', () => {
+    skipIfNoDockerRegistry(providerContext);
     before(async () => {
       await esArchiver.loadIfNeeded('fleet/agents');
 

x-pack/test/api_integration/apis/fleet/agents/checkin.ts renamed to x-pack/test/ingest_manager_api_integration/apis/fleet/agents/checkin.ts

@@ -6,8 +6,9 @@
 
 import expect from '@kbn/expect';
 
-import { FtrProviderContext } from '../../ftr_provider_context';
-import { setupIngest, getSupertestWithoutAuth } from './agents/services';
+import { FtrProviderContext } from '../../../../api_integration/ftr_provider_context';
+import { setupIngest, getSupertestWithoutAuth } from './services';
+import { skipIfNoDockerRegistry } from '../../../helpers';
 
 export default function (providerContext: FtrProviderContext) {
   const { getService } = providerContext;
@@ -19,6 +20,7 @@ export default function (providerContext: FtrProviderContext) {
   const esClient = getService('es');
 
   describe('fleet_agent_flow', () => {
+    skipIfNoDockerRegistry(providerContext);
     before(async () => {
       await esArchiver.load('empty_kibana');
     });

x-pack/test/api_integration/apis/fleet/agent_flow.ts renamed to x-pack/test/ingest_manager_api_integration/apis/fleet/agents/complete_flow.ts

@@ -5,7 +5,7 @@
  */
 
 import expect from '@kbn/expect';
-import { FtrProviderContext } from '../../ftr_provider_context';
+import { FtrProviderContext } from '../../../../api_integration/ftr_provider_context';
 
 export default function ({ getService }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');