Skip to content

Commit 8c4af6f

Browse files
kobelbelasticmachinekibanamachinewayneseymour
authored
Removing the code plugin entirely for 8.0 (#77940)
* Removing the code app entirely for 8.0 * Updating plugin list docs * Using a test plugin for the code_coverage integration tests * Fix borked test. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tre' Seymour <[email protected]>
1 parent 9fe8ccc commit 8c4af6f

File tree

11 files changed

+45
-119
lines changed

11 files changed

+45
-119
lines changed

docs/developer/plugin-list.asciidoc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -318,10 +318,6 @@ Failure to have auth enabled in Kibana will make for a broken UI. UI-based error
318318
|The cloud plugin adds cloud specific features to Kibana.
319319
320320
321-
|{kib-repo}blob/{branch}/x-pack/plugins/code[code]
322-
|WARNING: Missing README.
323-
324-
325321
|{kib-repo}blob/{branch}/x-pack/plugins/console_extensions/README.md[consoleExtensions]
326322
|This plugin provides autocomplete definitions of licensed APIs to the OSS Console plugin.
327323
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"id": "codeCoverageTestPlugin",
3+
"version": "kibana",
4+
"server": true,
5+
"ui": false
6+
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
/*
2+
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
3+
* or more contributor license agreements. Licensed under the Elastic License
4+
* 2.0 and the Server Side Public License, v 1; you may not use this file except
5+
* in compliance with, at your election, the Elastic License 2.0 or the Server
6+
* Side Public License, v 1.
7+
*/
8+
9+
import { Plugin } from './plugin';
10+
11+
export function plugin() {
12+
return new Plugin();
13+
}
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
/*
2+
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
3+
* or more contributor license agreements. Licensed under the Elastic License
4+
* 2.0 and the Server Side Public License, v 1; you may not use this file except
5+
* in compliance with, at your election, the Elastic License 2.0 or the Server
6+
* Side Public License, v 1.
7+
*/
8+
9+
import { CoreSetup } from 'kibana/server';
10+
11+
export class Plugin {
12+
constructor() {}
13+
14+
public setup(core: CoreSetup) {}
15+
16+
public start() {
17+
// called after all plugins are set up
18+
}
19+
20+
public stop() {
21+
// called when plugin is torn down during Kibana's shutdown sequence
22+
}
23+
}

src/dev/code_coverage/ingest_coverage/integration_tests/mocks/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
# For more info, see https://help.github.com/articles/about-codeowners/
44

55
# App
6-
/x-pack/plugins/code/ @elastic/kibana-tre
6+
/src/dev/code_coverage/ingest_coverage/integration_tests/fixtures/test_plugin @elastic/kibana-tre

src/dev/code_coverage/ingest_coverage/integration_tests/team_assignment.test.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,8 @@ describe('Team Assignment', () => {
3939
const { stdout } = await execa('grep', ['tre', teamAssignmentsPath], { cwd: ROOT_DIR });
4040
const lines = stdout.split('\n').filter((line) => !line.includes('/target'));
4141
expect(lines).toEqual([
42-
'x-pack/plugins/code/jest.config.js kibana-tre',
43-
'x-pack/plugins/code/server/config.ts kibana-tre',
44-
'x-pack/plugins/code/server/index.ts kibana-tre',
45-
'x-pack/plugins/code/server/plugin.test.ts kibana-tre',
46-
'x-pack/plugins/code/server/plugin.ts kibana-tre',
42+
'src/dev/code_coverage/ingest_coverage/integration_tests/fixtures/test_plugin/server/index.ts kibana-tre',
43+
'src/dev/code_coverage/ingest_coverage/integration_tests/fixtures/test_plugin/server/plugin.ts kibana-tre',
4744
]);
4845
});
4946
});

x-pack/plugins/code/kibana.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

x-pack/plugins/code/server/config.ts

Lines changed: 0 additions & 14 deletions
This file was deleted.

x-pack/plugins/code/server/index.ts

Lines changed: 0 additions & 14 deletions
This file was deleted.

x-pack/plugins/code/server/plugin.test.ts

Lines changed: 0 additions & 39 deletions
This file was deleted.

0 commit comments

Comments
 (0)