Skip to content

Commit 8be837a

Browse files
[Cases] Unskip flaky tests (#178370)
## Summary This PR unskip below flaky tests to confirm the fix made in #177798 Fixes #174682 Fixes #176336 Fixes #177334 Fixes #171600 Fixes #171601 Fixes #177791 Fixes #177792 Fixes #177793 Fixes #177794 Fixes #177795 Fixes #177796 Fixes #171605 Fixes #171606 Fixes #171607 Fixes #171608 Fixes #178119 Fixes #174525 Fixes #174526 Fixes #174527 Fixes #174528 Fixes #146394 Fixes #176805 Fixes #175112 Fixes #176671 Fixes #176672 Fixes #175841 Fixes #174667 Fixes #174384 Fixes #175310 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
1 parent aded174 commit 8be837a

File tree

15 files changed

+27
-51
lines changed

15 files changed

+27
-51
lines changed

x-pack/plugins/cases/public/components/all_cases/columns_popover.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ import type { AppMockRenderer } from '../../common/mock';
1414
import { createAppMockRenderer } from '../../common/mock';
1515
import { ColumnsPopover } from './columns_popover';
1616

17-
// FLAKY: https://github.com/elastic/kibana/issues/174682
18-
describe.skip('ColumnsPopover', () => {
17+
describe('ColumnsPopover', () => {
1918
let appMockRenderer: AppMockRenderer;
2019

2120
beforeEach(() => {

x-pack/plugins/cases/public/components/all_cases/severity_filter.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ import { screen, waitFor } from '@testing-library/react';
1414
import { waitForEuiPopoverOpen } from '@elastic/eui/lib/test/rtl';
1515
import { SeverityFilter } from './severity_filter';
1616

17-
// FLAKY: https://github.com/elastic/kibana/issues/176336
18-
describe.skip('Severity form field', () => {
17+
describe('Severity form field', () => {
1918
const onChange = jest.fn();
2019
let appMockRender: AppMockRenderer;
2120
const props = {

x-pack/plugins/cases/public/components/all_cases/status_filter.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ const LABELS = {
1919
inProgress: i18n.STATUS_IN_PROGRESS,
2020
};
2121

22-
// FLAKY: https://github.com/elastic/kibana/issues/177334
23-
describe.skip('StatusFilter', () => {
22+
describe('StatusFilter', () => {
2423
const onChange = jest.fn();
2524
const defaultProps = {
2625
selectedOptionKeys: [],

x-pack/plugins/cases/public/components/case_view/components/suggest_users_popover.test.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ import type { AssigneeWithProfile } from '../../user_profiles/types';
1818

1919
jest.mock('../../../containers/user_profiles/api');
2020

21-
// FLAKY: https://github.com/elastic/kibana/issues/171600
22-
// FLAKY: https://github.com/elastic/kibana/issues/171601
23-
describe.skip('SuggestUsersPopover', () => {
21+
describe('SuggestUsersPopover', () => {
2422
let appMockRender: AppMockRenderer;
2523
let defaultProps: SuggestUsersPopoverProps;
2624

x-pack/plugins/cases/public/components/category/category_form_field.test.tsx

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,7 @@ import { categories } from '../../containers/mock';
1616
import { MAX_CATEGORY_LENGTH } from '../../../common/constants';
1717
import { FormTestComponent } from '../../common/test_utils';
1818

19-
// FLAKY: https://github.com/elastic/kibana/issues/177791
20-
// FLAKY: https://github.com/elastic/kibana/issues/177792
21-
// FLAKY: https://github.com/elastic/kibana/issues/177793
22-
// FLAKY: https://github.com/elastic/kibana/issues/177794
23-
// FLAKY: https://github.com/elastic/kibana/issues/177795
24-
// FLAKY: https://github.com/elastic/kibana/issues/177796
25-
// FLAKY: https://github.com/elastic/kibana/issues/171605
26-
// FLAKY: https://github.com/elastic/kibana/issues/171606
27-
// FLAKY: https://github.com/elastic/kibana/issues/171607
28-
// FLAKY: https://github.com/elastic/kibana/issues/171608
29-
describe.skip('Category', () => {
19+
describe('Category', () => {
3020
let appMockRender: AppMockRenderer;
3121
const onSubmit = jest.fn();
3222

x-pack/plugins/cases/public/components/connectors/resilient/use_get_incident_types.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ jest.mock('./api');
1919

2020
const useKibanaMock = useKibana as jest.Mocked<typeof useKibana>;
2121

22-
// FLAKY: https://github.com/elastic/kibana/issues/178119
23-
describe.skip('useGetIncidentTypes', () => {
22+
describe('useGetIncidentTypes', () => {
2423
const { http } = useKibanaMock().services;
2524
let appMockRender: AppMockRenderer;
2625

x-pack/plugins/cases/public/components/create/flyout/create_case_flyout.test.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,7 @@ const defaultProps = {
3939
owner: 'securitySolution',
4040
};
4141

42-
// FLAKY: https://github.com/elastic/kibana/issues/174525
43-
// FLAKY: https://github.com/elastic/kibana/issues/174526
44-
// FLAKY: https://github.com/elastic/kibana/issues/174527
45-
// FLAKY: https://github.com/elastic/kibana/issues/174528
46-
describe.skip('CreateCaseFlyout', () => {
42+
describe('CreateCaseFlyout', () => {
4743
let appMockRenderer: AppMockRenderer;
4844

4945
beforeEach(() => {

x-pack/plugins/cases/public/components/create/form_context.test.tsx

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ const waitForFormToRender = async (renderer: Screen) => {
149149
});
150150
};
151151

152-
// Failing: See https://github.com/elastic/kibana/issues/146394
153-
describe.skip('Create case', () => {
152+
describe('Create case', () => {
154153
const refetch = jest.fn();
155154
const onFormSubmitSuccess = jest.fn();
156155
const afterCaseCreated = jest.fn();
@@ -466,26 +465,31 @@ describe.skip('Create case', () => {
466465
const textField = customFieldsConfigurationMock[0];
467466
const toggleField = customFieldsConfigurationMock[1];
468467

469-
expect(screen.getByTestId('create-case-custom-fields')).toBeInTheDocument();
468+
expect(await screen.findByTestId('create-case-custom-fields')).toBeInTheDocument();
470469

471-
userEvent.paste(
472-
screen.getByTestId(`${textField.key}-${textField.type}-create-custom-field`),
473-
'My text test value 1'
470+
const textCustomFieldEle = await screen.findByTestId(
471+
`${textField.key}-${textField.type}-create-custom-field`
474472
);
475473

474+
userEvent.clear(textCustomFieldEle);
475+
userEvent.paste(textCustomFieldEle, 'My text test value 1!!');
476+
476477
userEvent.click(
477-
screen.getByTestId(`${toggleField.key}-${toggleField.type}-create-custom-field`)
478+
await screen.findByTestId(`${toggleField.key}-${toggleField.type}-create-custom-field`)
478479
);
479480

480-
userEvent.click(screen.getByTestId('create-case-submit'));
481+
userEvent.click(await screen.findByTestId('create-case-submit'));
481482

482483
await waitFor(() => expect(postCase).toHaveBeenCalled());
483484

484485
expect(postCase).toBeCalledWith({
485486
request: {
486487
...sampleDataWithoutTags,
487488
customFields: [
488-
...customFieldsMock,
489+
{ ...customFieldsMock[0], value: 'My text test value 1!!' },
490+
{ ...customFieldsMock[1], value: false },
491+
{ ...customFieldsMock[2] },
492+
{ ...customFieldsMock[3], value: false },
489493
{
490494
key: 'my_custom_field_key',
491495
type: CustomFieldTypes.TEXT,

x-pack/plugins/cases/public/components/custom_fields/index.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ import { MAX_CUSTOM_FIELDS_PER_CASE } from '../../../common/constants';
1717
import { CustomFields } from '.';
1818
import * as i18n from './translations';
1919

20-
// FLAKY: https://github.com/elastic/kibana/issues/176805
21-
describe.skip('CustomFields', () => {
20+
describe('CustomFields', () => {
2221
let appMockRender: AppMockRenderer;
2322

2423
const props = {

x-pack/plugins/cases/public/components/custom_fields/toggle/edit.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ import { customFieldsMock, customFieldsConfigurationMock } from '../../../contai
1414
import userEvent from '@testing-library/user-event';
1515
import type { CaseCustomFieldToggle } from '../../../../common/types/domain';
1616

17-
// FLAKY: https://github.com/elastic/kibana/issues/175112
18-
describe.skip('Edit ', () => {
17+
describe('Edit ', () => {
1918
const onSubmit = jest.fn();
2019

2120
beforeEach(() => {

0 commit comments

Comments
 (0)