Deangularize and typescriptify ui/saved_object (#51562)

Author: kertal

src/legacy/core_plugins/kibana/public/dashboard/__tests__/get_saved_dashboard_mock.ts

@@ -41,5 +41,5 @@ export function getSavedDashboardMock(
     getQuery: () => ({ query: '', language: 'kuery' }),
     getFilters: () => [],
     ...config,
-  };
+  } as SavedObjectDashboard;
 }

src/legacy/core_plugins/kibana/public/dashboard/dashboard_app_controller.tsx

@@ -35,7 +35,7 @@ import {
   State,
   AppStateClass as TAppStateClass,
   KbnUrl,
-  SaveOptions,
+  SavedObjectSaveOpts,
   unhashUrl,
 } from './legacy_imports';
 import { FilterStateManager, IndexPattern } from '../../../data/public';
@@ -608,7 +608,7 @@ export class DashboardAppController {
      * @return {Promise}
      * @resolved {String} - The id of the doc
      */
-    function save(saveOptions: SaveOptions): Promise<SaveResult> {
+    function save(saveOptions: SavedObjectSaveOpts): Promise<SaveResult> {
       return saveDashboard(angular.toJson, timefilter, dashboardStateManager, saveOptions)
         .then(function(id) {
           if (id) {

src/legacy/core_plugins/kibana/public/dashboard/legacy_imports.ts

@@ -30,7 +30,7 @@ export const legacyChrome = chrome;
 export { State } from 'ui/state_management/state';
 export { AppState } from 'ui/state_management/app_state';
 export { AppStateClass } from 'ui/state_management/app_state';
-export { SaveOptions } from 'ui/saved_objects/saved_object';
+export { SavedObjectSaveOpts } from 'ui/saved_objects/types';
 export { npSetup, npStart } from 'ui/new_platform';
 export { SavedObjectRegistryProvider } from 'ui/saved_objects';
 export { IPrivate } from 'ui/private';

src/legacy/core_plugins/kibana/public/dashboard/lib/save_dashboard.ts

@@ -18,7 +18,7 @@
  */
 
 import { TimefilterContract } from 'src/plugins/data/public';
-import { SaveOptions } from '../legacy_imports';
+import { SavedObjectSaveOpts } from '../legacy_imports';
 import { updateSavedDashboard } from './update_saved_dashboard';
 import { DashboardStateManager } from '../dashboard_state_manager';
 
@@ -34,7 +34,7 @@ export function saveDashboard(
   toJson: (obj: any) => string,
   timeFilter: TimefilterContract,
   dashboardStateManager: DashboardStateManager,
-  saveOptions: SaveOptions
+  saveOptions: SavedObjectSaveOpts
 ): Promise<string> {
   dashboardStateManager.saveState();
 

src/legacy/core_plugins/kibana/public/dashboard/saved_dashboard/saved_dashboard.d.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { SavedObject } from 'ui/saved_objects/saved_object';
+import { SavedObject } from 'ui/saved_objects/types';
 import { SearchSourceContract } from '../../../../../ui/public/courier';
 import { esFilters, Query, RefreshInterval } from '../../../../../../plugins/data/public';
 

src/legacy/core_plugins/kibana/public/dashboard/saved_dashboard/saved_dashboards.js

@@ -22,6 +22,7 @@ import './saved_dashboard';
 import { uiModules } from 'ui/modules';
 import { SavedObjectLoader, SavedObjectsClientProvider } from 'ui/saved_objects';
 import { savedObjectManagementRegistry } from '../../management/saved_object_registry';
+import { npStart } from '../../../../../ui/public/new_platform';
 
 const module = uiModules.get('app/dashboard');
 
@@ -35,7 +36,7 @@ savedObjectManagementRegistry.register({
 });
 
 // This is the only thing that gets injected into controllers
-module.service('savedDashboards', function (Private, SavedDashboard, kbnUrl, chrome) {
+module.service('savedDashboards', function (Private, SavedDashboard) {
   const savedObjectClient = Private(SavedObjectsClientProvider);
-  return new SavedObjectLoader(SavedDashboard, kbnUrl, chrome, savedObjectClient);
+  return new SavedObjectLoader(SavedDashboard, savedObjectClient, npStart.core.chrome);
 });

src/legacy/core_plugins/kibana/public/discover/__tests__/directives/discover_field.js

@@ -32,7 +32,7 @@ describe('discoverField', function () {
   let $scope;
   let indexPattern;
   let $elem;
-  beforeEach(() => pluginInstance.initializeServices(true));
+  beforeEach(() => pluginInstance.initializeServices());
   beforeEach(() => pluginInstance.initializeInnerAngular());
   beforeEach(ngMock.module('app/discover'));
   beforeEach(ngMock.inject(function (Private, $rootScope, $compile) {

src/legacy/core_plugins/kibana/public/discover/__tests__/directives/field_chooser.js

@@ -70,7 +70,7 @@ describe('discover field chooser directives', function () {
       on-remove-field="removeField"
     ></disc-field-chooser>
   `);
-  beforeEach(() => pluginInstance.initializeServices(true));
+  beforeEach(() => pluginInstance.initializeServices());
   beforeEach(() => pluginInstance.initializeInnerAngular());
 
   beforeEach(ngMock.module('app/discover', ($provide) => {

src/legacy/core_plugins/kibana/public/discover/angular/context/query_parameters/__tests__/action_add_filter.js

@@ -27,7 +27,7 @@ import { npStart } from 'ui/new_platform';
 
 describe('context app', function () {
   beforeEach(() => pluginInstance.initializeInnerAngular());
-  beforeEach(() => pluginInstance.initializeServices(true));
+  beforeEach(() => pluginInstance.initializeServices());
   beforeEach(ngMock.module('app/discover'));
   beforeEach(ngMock.module(function createServiceStubs($provide) {
     $provide.value('indexPatterns', createIndexPatternsStub());

src/legacy/core_plugins/kibana/public/discover/angular/context/query_parameters/__tests__/action_set_predecessor_count.js

@@ -26,7 +26,7 @@ import { getQueryParameterActions } from '../actions';
 
 describe('context app', function () {
   beforeEach(() => pluginInstance.initializeInnerAngular());
-  beforeEach(() => pluginInstance.initializeServices(true));
+  beforeEach(() => pluginInstance.initializeServices());
   beforeEach(ngMock.module('app/discover'));
 
   describe('action setPredecessorCount', function () {