[8.19] Updated js-yaml to v4 (#190678) (#219852)

# Backport

This will backport the following commits from `main` to `8.19`:
- [Updated js-yaml to v4
(#190678)](#190678)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Elena
Shostak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T10:25:03Z","message":"Updated
js-yaml to v4 (#190678)\n\n## Summary\r\nUpdated `js-yaml` to
`4.1.0`.\r\n\r\nThis PR also introduces a type override for the
`js-yaml` load function\r\nto maintain compatibility across the
codebase. Specifically, updated\r\ntype definition of the load function
looks as follows:\r\n\r\n```typescript\r\nfunction load<T = any>(str:
string, opts?: jsyaml.LoadOptions): T;\r\n```\r\n\r\nThe original type
definition of the load function in `js-yaml` changed\r\nfrom `any` to
`unknown`. This change would require extensive type\r\nupdates
throughout the entire repository to accommodate the `unknown`\r\ntype.
To avoid widespread type changes and potential issues in
the\r\ncodebase, the type is overriden back to `any` for now.\r\nThis is
a temporary measure, we plan to address the necessary type\r\nchanges in
subsequent PRs, where teams will gradually update the\r\ncodebase to
work with the `unknown` type.\r\n\r\n\r\n### Checklist\r\n\r\n- [x]
[Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n## Release
note\r\nUpdated `js-yaml` to
`4.1.0`.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Maxim Palenov
<[email protected]>","sha":"28aa274f665b1aff891bf055a592851c8ec53d30","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Security","backport:skip","Team:Fleet","v9.0.0","Team:Obs
AI
Assistant","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","apm:review"],"title":"Updated
js-yaml to
v4","number":190678,"url":"https://github.com/elastic/kibana/pull/190678","mergeCommit":{"message":"Updated
js-yaml to v4 (#190678)\n\n## Summary\r\nUpdated `js-yaml` to
`4.1.0`.\r\n\r\nThis PR also introduces a type override for the
`js-yaml` load function\r\nto maintain compatibility across the
codebase. Specifically, updated\r\ntype definition of the load function
looks as follows:\r\n\r\n```typescript\r\nfunction load<T = any>(str:
string, opts?: jsyaml.LoadOptions): T;\r\n```\r\n\r\nThe original type
definition of the load function in `js-yaml` changed\r\nfrom `any` to
`unknown`. This change would require extensive type\r\nupdates
throughout the entire repository to accommodate the `unknown`\r\ntype.
To avoid widespread type changes and potential issues in
the\r\ncodebase, the type is overriden back to `any` for now.\r\nThis is
a temporary measure, we plan to address the necessary type\r\nchanges in
subsequent PRs, where teams will gradually update the\r\ncodebase to
work with the `unknown` type.\r\n\r\n\r\n### Checklist\r\n\r\n- [x]
[Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n## Release
note\r\nUpdated `js-yaml` to
`4.1.0`.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Maxim Palenov
<[email protected]>","sha":"28aa274f665b1aff891bf055a592851c8ec53d30"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190678","number":190678,"mergeCommit":{"message":"Updated
js-yaml to v4 (#190678)\n\n## Summary\r\nUpdated `js-yaml` to
`4.1.0`.\r\n\r\nThis PR also introduces a type override for the
`js-yaml` load function\r\nto maintain compatibility across the
codebase. Specifically, updated\r\ntype definition of the load function
looks as follows:\r\n\r\n```typescript\r\nfunction load<T = any>(str:
string, opts?: jsyaml.LoadOptions): T;\r\n```\r\n\r\nThe original type
definition of the load function in `js-yaml` changed\r\nfrom `any` to
`unknown`. This change would require extensive type\r\nupdates
throughout the entire repository to accommodate the `unknown`\r\ntype.
To avoid widespread type changes and potential issues in
the\r\ncodebase, the type is overriden back to `any` for now.\r\nThis is
a temporary measure, we plan to address the necessary type\r\nchanges in
subsequent PRs, where teams will gradually update the\r\ncodebase to
work with the `unknown` type.\r\n\r\n\r\n### Checklist\r\n\r\n- [x]
[Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n## Release
note\r\nUpdated `js-yaml` to
`4.1.0`.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Maxim Palenov
<[email protected]>","sha":"28aa274f665b1aff891bf055a592851c8ec53d30"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>

Author: elena-shostak

.buildkite/pipeline-resource-definitions/scripts/fix-location-collection.ts

@@ -38,15 +38,13 @@ async function main() {
 
   const preamble = locationFileLines.slice(0, 1);
 
-  // eslint-disable-next-line @kbn/eslint/no_unsafe_js_yaml
   const locationObj = jsYaml.load(
     locationFileLines.slice(1).join('\n')
   ) as BackstageLocationResource;
   locationObj.spec.targets = pipelines.map(
     (fileName) => `${resourceDefinitionsBaseUrl}/${fileName}`
   );
 
-  // eslint-disable-next-line @kbn/eslint/no_unsafe_js_yaml
   const locationYaml = jsYaml.dump(locationObj, { lineWidth: 400 });
 
   fs.writeFileSync(locationFile, `${preamble.join('\n')}\n${locationYaml}`);

.buildkite/pipeline-utils/agent_images.ts

@@ -7,7 +7,6 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-// eslint-disable-next-line @kbn/eslint/no_unsafe_js_yaml
 import { dump } from 'js-yaml';
 import { BuildkiteClient, BuildkiteAgentTargetingRule } from './buildkite';
 

.buildkite/pipeline-utils/buildkite/client.ts

@@ -10,7 +10,6 @@
 import axios, { AxiosInstance } from 'axios';
 import { execSync, ExecSyncOptions } from 'child_process';
 
-// eslint-disable-next-line @kbn/eslint/no_unsafe_js_yaml
 import { dump } from 'js-yaml';
 
 import { parseLinkHeader } from './parse_link_header';

.buildkite/pipeline-utils/ci-stats/pick_test_group_run_order.ts

@@ -12,7 +12,6 @@ import * as Fs from 'fs';
 import * as globby from 'globby';
 import minimatch from 'minimatch';
 
-// eslint-disable-next-line @kbn/eslint/no_unsafe_js_yaml
 import { load as loadYaml } from 'js-yaml';
 
 import { BuildkiteClient, BuildkiteStep } from '../buildkite';

package.json

@@ -1177,7 +1177,7 @@
     "jquery": "^3.7.1",
     "js-search": "^1.4.3",
     "js-sha256": "^0.11.0",
-    "js-yaml": "^3.14.1",
+    "js-yaml": "^4.1.0",
     "json-schema-to-ts": "^2.9.1",
     "json-stable-stringify": "^1.0.1",
     "json-stringify-pretty-compact": "1.2.0",
@@ -1634,7 +1634,7 @@
     "@types/jest": "^29.5.3",
     "@types/jquery": "^3.5.32",
     "@types/js-search": "^1.4.0",
-    "@types/js-yaml": "^3.11.1",
+    "@types/js-yaml": "^4.0.9",
     "@types/jsdom": "^20.0.1",
     "@types/json-schema": "^7.0.15",
     "@types/json-stable-stringify": "^1.0.32",

packages/kbn-docs-utils/src/mdx/get_all_doc_file_ids.ts

@@ -38,7 +38,7 @@ export async function getAllDocFileIds(outputDir: string) {
 
     let fm;
     try {
-      fm = Yaml.safeLoad(fmYaml.slice(0, fmEnd.index));
+      fm = Yaml.load(fmYaml.slice(0, fmEnd.index));
       if (typeof fm !== 'object' || fm === null) {
         throw new Error('expected yaml to produce an object');
       }

packages/kbn-docs-utils/tsconfig.json

@@ -9,6 +9,7 @@
   },
   "include": [
     "**/*.ts",
+    "../../typings/**/*"
   ],
   "exclude": [
     "**/__fixtures__/**",

packages/kbn-eslint-config/.eslintrc.js

@@ -323,7 +323,6 @@ module.exports = {
     '@kbn/eslint/no_constructor_args_in_property_initializers': 'error',
     '@kbn/eslint/no_this_in_property_initializers': 'error',
     '@kbn/eslint/no_unsafe_console': 'error',
-    '@kbn/eslint/no_unsafe_js_yaml': 'error',
     '@kbn/imports/no_unresolvable_imports': 'error',
     '@kbn/imports/uniform_imports': 'error',
     '@kbn/imports/no_unused_imports': 'error',

packages/kbn-eslint-plugin-eslint/index.js

@@ -19,6 +19,5 @@ module.exports = {
     no_constructor_args_in_property_initializers: require('./rules/no_constructor_args_in_property_initializers'),
     no_this_in_property_initializers: require('./rules/no_this_in_property_initializers'),
     no_unsafe_console: require('./rules/no_unsafe_console'),
-    no_unsafe_js_yaml: require('./rules/no_unsafe_js_yaml'),
   },
 };