Skip to content

Commit 7143db3

Browse files
committed
avoid using .all stdout collection, it seems unreliable
1 parent eefa5b1 commit 7143db3

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

packages/kbn-plugin-helpers/src/integration_tests/build.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,10 @@ it('builds a generated plugin into a viable archive', async () => {
5050
[require.resolve('../../../../scripts/generate_plugin'), '-y', '--name', 'fooTestPlugin'],
5151
{
5252
cwd: REPO_ROOT,
53-
all: true,
5453
}
5554
);
5655

57-
expect(generateProc.all).toMatchInlineSnapshot(`
56+
expect(generateProc.stdout).toMatchInlineSnapshot(`
5857
" succ 🎉
5958
6059
Your plugin has been created in plugins/foo_test_plugin
@@ -63,10 +62,9 @@ it('builds a generated plugin into a viable archive', async () => {
6362

6463
const buildProc = await execa('yarn', ['build', '--kibana-version', '7.5.0'], {
6564
cwd: PLUGIN_DIR,
66-
all: true,
6765
});
6866

69-
expect(buildProc.all).toMatchInlineSnapshot(`
67+
expect(buildProc.stdout).toMatchInlineSnapshot(`
7068
"yarn run <version>
7169
$ yarn plugin-helpers build --kibana-version 7.5.0
7270
$ node ../../scripts/plugin_helpers build --kibana-version 7.5.0

0 commit comments

Comments
 (0)