Skip to content

Commit 632db37

Browse files
authored
Stabilize closing toast (#72097) (#73200)
1 parent c23219f commit 632db37

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

test/functional/apps/dashboard/dashboard_snapshots.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ export default function ({ getService, getPageObjects, updateBaselines }) {
2828
const dashboardPanelActions = getService('dashboardPanelActions');
2929
const dashboardAddPanel = getService('dashboardAddPanel');
3030

31-
// SKIPPED as it is failing in ES PROMOTION: https://github.com/elastic/kibana/issues/68595
32-
// FLAKY: https://github.com/elastic/kibana/issues/52854
33-
describe.skip('dashboard snapshots', function describeIndexTests() {
31+
describe('dashboard snapshots', function describeIndexTests() {
3432
before(async function () {
3533
await esArchiver.load('dashboard/current/kibana');
3634
await kibanaServer.uiSettings.replace({

test/functional/page_objects/common_page.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,11 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
401401
async closeToastIfExists() {
402402
const toastShown = await find.existsByCssSelector('.euiToast');
403403
if (toastShown) {
404-
await this.closeToast();
404+
try {
405+
await this.closeToast();
406+
} catch (err) {
407+
// ignore errors, toast clear themselves after timeout
408+
}
405409
}
406410
}
407411

0 commit comments

Comments
 (0)