Skip to content

Commit 5f2cc01

Browse files
authored
[Code]: fix new eslint errors (#34671)
1 parent e90a928 commit 5f2cc01

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+228
-190
lines changed

x-pack/plugins/code/model/highlight.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* you may not use this file except in compliance with the Elastic License.
55
*/
66

7-
export interface CodeLine extends Array<Token> {}
7+
export type CodeLine = Token[];
88

99
export interface Token {
1010
value: string;

x-pack/plugins/code/public/components/admin_page/language_server_tab.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const LanguageServerLi = (props: {
4747
} else if (name === 'Java') {
4848
return <JavaIcon />;
4949
} else if (name === 'Go') {
50-
return <GoIcon />
50+
return <GoIcon />;
5151
}
5252
};
5353

x-pack/plugins/code/public/components/admin_page/project_item.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ class CodeProjectItem extends React.PureComponent<{
114114
<div
115115
className="code-project-button"
116116
data-test-subj="settingsRepositoryButton"
117+
tabIndex={0}
118+
onKeyDown={onClickSettings}
117119
onClick={onClickSettings}
118120
role="button"
119121
style={{ visibility: settingsVisibility }}
@@ -128,6 +130,8 @@ class CodeProjectItem extends React.PureComponent<{
128130
<div
129131
className="code-project-button"
130132
data-test-subj="indexRepositoryButton"
133+
tabIndex={0}
134+
onKeyDown={onClickIndex}
131135
onClick={onClickIndex}
132136
role="button"
133137
style={{ visibility: indexVisibility }}
@@ -142,6 +146,8 @@ class CodeProjectItem extends React.PureComponent<{
142146
<div
143147
className="code-project-button"
144148
data-test-subj="deleteRepositoryButton"
149+
tabIndex={0}
150+
onKeyDown={onClickDelete}
145151
onClick={onClickDelete}
146152
role="button"
147153
style={{ visibility: deleteVisibility }}

x-pack/plugins/code/public/components/admin_page/project_tab.tsx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -42,35 +42,35 @@ const NewProjectButton = styled(EuiButton)`
4242
`;
4343

4444
enum SortOptionsValue {
45-
alphabetical_asc = 'alphabetical_asc',
46-
alphabetical_desc = 'alphabetical_desc',
47-
updated_asc = 'updated_asc',
48-
updated_desc = 'updated_desc',
49-
recently_added = 'recently_added',
45+
AlphabeticalAsc = 'alphabetical_asc',
46+
AlphabeticalDesc = 'alphabetical_desc',
47+
UpdatedAsc = 'updated_asc',
48+
UpdatedDesc = 'updated_desc',
49+
RecentlyAdded = 'recently_added',
5050
}
5151

5252
const sortFunctionsFactory = (status: { [key: string]: RepoStatus }) => {
5353
const sortFunctions: { [k: string]: (a: Repository, b: Repository) => number } = {
54-
[SortOptionsValue.alphabetical_asc]: (a: Repository, b: Repository) =>
54+
[SortOptionsValue.AlphabeticalAsc]: (a: Repository, b: Repository) =>
5555
a.name!.localeCompare(b.name!),
56-
[SortOptionsValue.alphabetical_desc]: (a: Repository, b: Repository) =>
56+
[SortOptionsValue.AlphabeticalDesc]: (a: Repository, b: Repository) =>
5757
b.name!.localeCompare(a.name!),
58-
[SortOptionsValue.updated_asc]: (a: Repository, b: Repository) =>
58+
[SortOptionsValue.UpdatedAsc]: (a: Repository, b: Repository) =>
5959
moment(status[b.uri].timestamp).diff(moment(status[a.uri].timestamp)),
60-
[SortOptionsValue.updated_desc]: (a: Repository, b: Repository) =>
60+
[SortOptionsValue.UpdatedDesc]: (a: Repository, b: Repository) =>
6161
moment(status[a.uri].timestamp).diff(moment(status[b.uri].timestamp)),
62-
[SortOptionsValue.recently_added]: () => {
62+
[SortOptionsValue.RecentlyAdded]: () => {
6363
return -1;
6464
},
6565
};
6666
return sortFunctions;
6767
};
6868

6969
const sortOptions = [
70-
{ value: SortOptionsValue.alphabetical_asc, inputDisplay: 'A to Z' },
71-
{ value: SortOptionsValue.alphabetical_desc, inputDisplay: 'Z to A' },
72-
{ value: SortOptionsValue.updated_asc, inputDisplay: 'Last Updated ASC' },
73-
{ value: SortOptionsValue.updated_desc, inputDisplay: 'Last Updated DESC' },
70+
{ value: SortOptionsValue.AlphabeticalAsc, inputDisplay: 'A to Z' },
71+
{ value: SortOptionsValue.AlphabeticalDesc, inputDisplay: 'Z to A' },
72+
{ value: SortOptionsValue.UpdatedAsc, inputDisplay: 'Last Updated ASC' },
73+
{ value: SortOptionsValue.UpdatedDesc, inputDisplay: 'Last Updated DESC' },
7474
// { value: SortOptionsValue.recently_added, inputDisplay: 'Recently Added' },
7575
];
7676

@@ -109,7 +109,7 @@ class CodeProjectTab extends React.PureComponent<Props, State> {
109109
showImportProjectModal: false,
110110
settingModal: { show: false },
111111
repoURL: '',
112-
sortOption: SortOptionsValue.alphabetical_asc,
112+
sortOption: SortOptionsValue.AlphabeticalAsc,
113113
isInvalid: false,
114114
};
115115
}

x-pack/plugins/code/public/components/diff_page/commit_link.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* or more contributor license agreements. Licensed under the Elastic License;
44
* you may not use this file except in compliance with the Elastic License.
55
*/
6-
import { EuiBadge /*, EuiLink*/ } from '@elastic/eui';
6+
import { EuiBadge /* , EuiLink*/ } from '@elastic/eui';
77
import React from 'react';
88
// import { DIFF } from '../routes';
99

x-pack/plugins/code/public/components/file_tree/__snapshots__/file_tree.test.tsx.snap

Lines changed: 48 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugins/code/public/components/file_tree/file_tree.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* or more contributor license agreements. Licensed under the Elastic License;
44
* you may not use this file except in compliance with the Elastic License.
55
*/
6+
67
import React from 'react';
78

89
import { EuiIcon, EuiSideNav, EuiText } from '@elastic/eui';
@@ -114,6 +115,8 @@ export class CodeFileTree extends React.Component<Props> {
114115
data-test-subj={`codeFileTreeNode-Directory-${node.path}`}
115116
className={className}
116117
role="button"
118+
tabIndex={0}
119+
onKeyDown={onClick}
117120
onClick={onClick}
118121
>
119122
{forceOpen ? (
@@ -142,6 +145,8 @@ export class CodeFileTree extends React.Component<Props> {
142145
<Container>
143146
<div
144147
data-test-subj={`codeFileTreeNode-Submodule-${node.path}`}
148+
tabIndex={0}
149+
onKeyDown={onClick}
145150
onClick={onClick}
146151
className={classes(className, 'code-file-tree-file')}
147152
role="button"
@@ -162,6 +167,8 @@ export class CodeFileTree extends React.Component<Props> {
162167
<Container>
163168
<div
164169
data-test-subj={`codeFileTreeNode-Link-${node.path}`}
170+
tabIndex={0}
171+
onKeyDown={onClick}
165172
onClick={onClick}
166173
className={classes(className, 'code-file-tree-file')}
167174
role="button"
@@ -182,6 +189,8 @@ export class CodeFileTree extends React.Component<Props> {
182189
<Container>
183190
<div
184191
data-test-subj={`codeFileTreeNode-File-${node.path}`}
192+
tabIndex={0}
193+
onKeyDown={onClick}
185194
onClick={onClick}
186195
className={classes(className, 'code-file-tree-file')}
187196
role="button"

0 commit comments

Comments
 (0)