Skip to content

Commit 5ba502c

Browse files
committed
Review changes
1 parent 9e52760 commit 5ba502c

File tree

3 files changed

+4
-19
lines changed

3 files changed

+4
-19
lines changed

x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/components/builtin_action_types/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export interface IndexActionParams {
4242
index?: string;
4343
refresh?: boolean;
4444
executionTimeField?: string;
45-
documents?: string[];
45+
documents: string[];
4646
}
4747

4848
export enum ServerLogLevelOptions {
@@ -55,7 +55,7 @@ export enum ServerLogLevelOptions {
5555
}
5656

5757
export interface ServerLogActionParams {
58-
level: ServerLogLevelOptions;
58+
level?: ServerLogLevelOptions;
5959
message: string;
6060
}
6161

x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/application/sections/action_connector_form/action_connector_form.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export const ActionConnectorForm = ({
7777
title={i18n.translate(
7878
'xpack.triggersActionsUI.sections.actionConnectorForm.actions.actionTypeConfigurationWarningTitleText',
7979
{
80-
defaultMessage: 'Action type may not be configured',
80+
defaultMessage: 'Action type not registered',
8181
}
8282
)}
8383
color="warning"

x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/types.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,6 @@
66
import { ActionType } from '../../../../../plugins/actions/common';
77
import { TypeRegistry } from './application/type_registry';
88
import { SanitizedAlert as Alert, AlertAction } from '../../../alerting/common';
9-
import {
10-
EmailActionParams,
11-
PagerDutyActionParams,
12-
IndexActionParams,
13-
ServerLogActionParams,
14-
WebhookActionParams,
15-
SlackActionParams,
16-
} from './application/components/builtin_action_types/types';
179
export { Alert, AlertAction };
1810
export { ActionType };
1911

@@ -51,14 +43,7 @@ export interface ActionTypeModel {
5143
validateConnector: (connector: any) => ValidationResult;
5244
validateParams: (actionParams: any) => ValidationResult;
5345
actionConnectorFields: React.FunctionComponent<any> | null;
54-
actionParamsFields:
55-
| React.FunctionComponent<ActionParamsProps<EmailActionParams>>
56-
| React.FunctionComponent<ActionParamsProps<IndexActionParams>>
57-
| React.FunctionComponent<ActionParamsProps<PagerDutyActionParams>>
58-
| React.FunctionComponent<ActionParamsProps<ServerLogActionParams>>
59-
| React.FunctionComponent<ActionParamsProps<SlackActionParams>>
60-
| React.FunctionComponent<ActionParamsProps<WebhookActionParams>>
61-
| null;
46+
actionParamsFields: any;
6247
}
6348

6449
export interface ValidationResult {

0 commit comments

Comments
 (0)